Áruházi oldal
RimWorld
Összes Témák Képernyőmentések Alkotások Közvetítések Videók Műhely Hírek Útmutatók Értékelések
RimWorld >  Műhely > Goji Műhelye > Goji's Fantasy Race: Merren > Témák
Goji's Fantasy Race: Merren
Leírás Témák4 Megjegyzések279 Változásjegyzék
royallyTipsy nov. 28., 14:51
A long list of tiny issues
Hello again! I wasn't sure if it was better to post this list as a discussion here, make more pull requests in Github, or perhaps even reach out to you through some other means (e.g. Discord). If any of those other ways is preferable, please do say so! Steam discussions aren't the best way to make a speedy conversation tbh XD

With that said, here's my list:
  • I'll start from the very tiniest - the Coastal Rescuer (Stagz_Rescuer) background has "housecarl" as short title, instead of e.g. "rescuer" you probably want.
  • An edgecase rather than an issue - your mod provides an example of creating a new tail gene in case anyone wants a specific tail color to be present in the game. In practice, the new tail gene will have at least one feature lacking: because the mod patches Nudist thoughts via XML, it won't adjust to a new tail gene being in the list. I know that in general XML patches are preferred but this appears to be a fairly trivial thing to C#. (Or you could just add that bit to the tutorial, I suppose)
  • I'm pretty sure inkshooter dryad is making wrong shooting sounds. The inkshooting gizmo is also missing proper description (it is using dryad's own general desc). I am assuming the firefoam trail is at least intentional, though it's a bit at odds with the idea of it shooting ink.
  • Lanterns can be placed on *anything* that supports bridgeable, which means land terrain like mud.
  • I think you can safely kill Pawn_PathFollower_Patches.cs now? Far as I can tell, it was used only by Aquatic pathfinding.
  • Ariel, the Merren joiner from the "pawn downed near water" and "virtuoso" events, is hardcoded to spawn as a member of friendly ancients faction. This is an issue in two ways: s/he spawns with synthread apparel, and her/his ideology will be the same as other ancients, which usually includes precepts like Transhumanism. S/he also spawns with gasmask in polluted tiles but that can be fixed with <apparelIgnorePollution>true</apparelIgnorePollution> in PawnKindDef.
  • Issue with repo rather than mod - .csproj does not actually need to reference BadHygiene.dll, because of how its Harmony patch is written. It won't cause any issues in the actual mod either way, it just makes it slightly more annoying to build the project for anyone who might try to clone the repo (inc me). While at it - dammit that method is called "hygene" and it's driving my grammar nazi up the wall.
  • Mod page here still has thumbnail with 1.4 in the corner. Some people do watch that.

I will top off this post with a set of small suggestions for Ariel. S/he is trivial to make spawn with Merren backgrounds only; her/his weapons could possibly use a bit of variance; s/he can be made to spawn with quackweed instead of pemmican, which I found exceedingly fitting although that requires that quackweed is not hidden behind Vanilla Plants Expanded requirement.
Legutóbb szerkesztette: royallyTipsy; dec. 4., 4:42
< >
1–3/3 megjegyzés mutatása
royallyTipsy dec. 4., 13:13 
TIL that vanilla supports ShallowWater for terrainAffordanceNeeded, which is probably exactly what we all imagine for the floating lanterns.
#1
Goji  [Fejlesztő] 18 órája 
Hi there, thanks so much for the dedicated bug spotting! My Discord is goji2337 if you'd prefer to chat there. I don’t have notifications on for discussion so apologies for the delay.

I've noted everything and will pass it along to Taran/Arquebus (again I’m coding inept myself 😅).

Simple stuff like the title/thumbnail I could fix myself, but I’ve been sidetracked by other mods lately. (fixing the trait mod and I have the mushroom&snail race coming up)

A couple things might be intentional (if my memory serves): the lantern was designed to be placeable on mud/marsh -- when Arquebus dug into the code, those were considered “wet terrain.” The Inkshooter doesn’t have custom sounds because I didn’t want to pay for commissions, xD. The Fireform is meant to represent seaform. Though it does feel like an odd design choice, I might remove it.

The more technical questions will need the coder’s attention (Taran’s schedule is so packed!!). I don’t understand half of it myself, but I trust your words. Thanks again for helping polish this mod with me!
Legutóbb szerkesztette: Goji; 16 órája
#2
royallyTipsy 2 órája 
> sorry for delay
I knew that I'd have to settle for a long wait if I made it a discussion, so it's no big deal. But yeah I find you in Discord once I make this reply.

> again I’m coding inept myself
I'm hardly coding adept myself. I'm just a pedantic rookie with a fair bit of free time on my hands. With half of my suggestions I am not sure if it's the best way to go about them, so I'm glad you have a pro who can double-check it all.

> snail race
That vividly reminded me of Mollopods from Starbound, they were so cute and colorful. If this is anything similar I'd be hyped.

> lantern
After a bit more testing, I find out that ShallowWater does not include chest-deep water. So yeah leaving it at Bridgeable may be best after all. What did I say about not being coding adept?

> rest of it
...should probably go into Discord, yeah.
#3
< >
1–3/3 megjegyzés mutatása
Laponként: 1530 50