Hey folks.

So fun news, I tested this with "Player as Knight" and guess what? It worked. Meaning that players under lieges can get called up as knights (or commanders) and means you can level up both sides of the traits at the same time.

It was only one file out of all of them. Not many, and it shouldn't cause any issues re: game. The encoding mostly causes issues with localization/display.

Unless you have massive amounts of errors re: other mods, the bloat from this won't impact you. I didn't even notice because I play via cloudgaming and don't see the useless errorlog.

But I've just fixed that file. Thanks for your report!

Many txt or yml files in this mod are not encoded with BOM and will have errors in errors.log. Could you fix it?

Thanks for the extensive answer! I appreciate you laying out your thoughts like that, I won't press you any further, just thought it was worth looking into

That said, I always appreciate polite suggestions and feedback! I may revisit tracked-style visuals in the future if I have a flash of an idea to make it work the way I want.

At the end of the day, I could do it. I may. I just really try to keep all of my mods as low-maintenance and compatible as possible (I have a few files I need to go through actually and make more compatible so they don't overwrite anything since I've been on a binge lately) - so that players can use these and other mods. You'll note even a lot of small mods have complicated parts that do not play well with others. Tracked traits are also a lot more breakable with patches and dlcs. You'll note there are tracked trait mods from when they introduced the change, that no longer work.

Whereas I have a mod in my workshop from like 4 years ago that still works today, on Elder Kings - despite me making it years ago.

Right now, with mystandard leveled traits, my system is basically:

Battle → script increments battle count → Check threshold → Upgrade trait tier

With tracked traits, it becomes:

Battle → script sets a flag/increments XP → UI tracked system records XP → Check threshold → Engine upgrades trait tier

Tracked traits and leveled traits are both grouped traits. The difference is how the engine handles their appearance, and how they track xp. In addition to my below issues, every time a battle is won - I'd have to add an additional flag/xp check which... with 80 possible traits impacting possibly every single character in the game, these add up. I'm amazed, amazed the game runs as well as it does with this mod regardless. I personally have noticed a huge performance uptick in the last patch (presumably due to their graphical downgrade for a larger map, which I approve of).

This mod could be a beast of a performance hog, instead it's nearly undetectable. In addition, you have no idea how complicated localization + bug tracking gets with tracked leveled traits. Even doing just 5-10 traits in my initial run was frustrating when things went awry.

I like your mods, my suggestion would be to have leveled traits instead of 80 standalone traits, I played a bit with the Highlander immortals 2 mod and that trait has 10 levels, maybe someting to consider?

Amazing, thank you for the quick response :)

The traits that are added are very different. Truie has different triggers, so they should be compatible.

Do you think this would be compatible with I am Full Truie's Commanders+? Since this mod also adds in Commander traits

Battle events and other battle mods should be fine.

All this does is track when battles are won, and give you traits based on the # of victories for Knights/Commanders.

There should be no vanilla files edited at the moment. @unknown keyed me into the last one I believe? (I built this mod off the bones of an old no longer continued mod, and that had a lot of errors in it)

@Renown , hello , does mod alter any vanilla files ? Does is compatible with battle events ?thanks

oh, well figured out why I never saw it. I have the other half of the file properly formed in another mod I built off of it, and was overriding it.

good eye, I've been using the same on_actions since I ripped it from the original War Veterans mod in 2021 . I've never had a problem so I've never looked at it. (by never had a problem, I never play games long enough to notice)

I assume there must be something left over to either an event from vanilla or something. I just redid it myself so there should be no more problems.

Didn't even realize it was an overriding file tbh.

your on_action\vets_combat_on_actions.txt is bad. Probably missing trailing brackets.
notice you don't get any commander trait xp for terrain/army size/defender because the commander_trait_leveling_leveling_effect never triggers. Maybe it happens only if there's more mods with on_combat_end_winner, but your block still contains much more than it needs to (which also differs from vanilla btw). So I made a block with just your 2 events and it works perfectly again.

on_combat_end_winner = {
events = {
combat_event.0041 # commmander gains traits from combat wins
combat_event.0042 # Commander gains traits from combat wins
}
}

@unknown, huh, must have been an oversight, thanks!

As to raid/hostile_county attrition.

I never touch hostile_country attrition, the modifier never makes sense the way it's applied by the game.

As to raiding, I too raid a lot. I indeed have my own raid mod I use, but I haven't released it where I expand the Raider traits. I do not add a lot of traits in this mod because of how I view the traits and the experiences, for one raid is not war. (the lifestyle experience is basically the closest thing to "general learning" experiences to account for war).

But to each their own. Edit it as you see fit!

bhcommander_31 till _35 have
monthly_martial_lifestyle_xp_gain_mult
instead of
monthly_lifestyle_xp_gain_mult
-- probably unintended

also for flavor for myself I have replaced xp and prestige gain with more attractive
raid_speed = 0.02
hostile_county_attrition = -0.02

The first 10 traits are fairly easily gained. You'll notice a lot of AI characters gaining these traits.

(Because there is a five battle requirement per trait).

I did this because I noticed with ten battle requirements at the start, fewer AI characters were gaining it.

I like the RPG aspect, and thus I lowered the values of a lot of the early levels and boosted the ease of getting them.

Alright. Massive update. original trait system properly split into two now. No longer will your knights and commanders get the same traits.

more traits. more bonuses. more spread out. new names. new graphics (let me know what you think).

Patching this as we speak. Adding 30 new trait images and splitting the trait system into two.

From here on out there will be a Commander trait line and Veteran trait line. Veteran traits apply to Knights only (and add accolade/prowess/prestige) and Commander lines add to Martial/army/prestige bonuses.

It felt weird to me to have Knights gaining the prior traits, especially since they wouldn't necessarily gain those skills as Knights. So I made a new image for commanders, and split the traits. This will probably break all pre-existing saves for all COMMANDER level traits, as they are getting moved.

So what this will mean is all Knights will just have new titles and bonuses, but all commanders will get their counters reset, and all previous traits will probably remain as the Commander trigger/counter starts afresh.

Also changing the titles slightly making them hyphenated and they need to make sense with the new traits.

Sorry, hope this doesn't bother anyone!

Please let me know what you think. I start so many campaigns I find it hard to see how my mods function 200 years in. I just can't stop tinkering.

Ah ok, I'll definitely try it out

hmm, I must have deleted that component of the description. It tracks knights & commanders.

What about knights?

But it will begin tracking from mod inclusion, can't track battles from prior to the mod.

It will be. Presuming you do not run a likewise mod (War veterans, Wargod, or something similar).

Save game compatible?

you'll get over it.

so sad to see battlefather go