Updated to v1.4:
- Updated for Vanilla 1.10 culture mechanics
- Decisions now add traditions to primary cultures instead of adding new primary cultures to the country

Just to not be a total lazy ass I have disabled all mods apart from this one and started a new game, let the game run for a month and seems like no memory leak. So must be a interaction between certain mods I'm running. You can probably disregard :).

That's... odd. I'll check on this on the weekend.

Hi Grey, firstly thank you so much for all of your useful mods. I have a fair few mods enabled and am not A tech wiz so it could definitely be just an interaction between certain mods i have enabled but i was suffering A memory leak in my game and it seemed to disappear once i disabled this mod in particular.

v1.3
- Integrated the East Asian Namelist Improvement mod to resolve conflicts and solve other occasional issues that crop up when combining this with other mods.
# Credit:
# - awak (author of East Asian Namelist Improvement MOD)
# - hamane (research on 19th century Ainu names)

So, 1.9 is right around the corner and I am excited to spend a chunk of time on modding and playing it. I've also just finished up with a very busy time in my life, and part of that is that I am currently unemployed.

So, since I have no job and I'm about to spend a chunk of time on modding when the update drops, I have now set up a Patreon on the off chance anyone would like to support me with a couple dollars. Link [patreon.com]

I will of course keep modding either way, but I would appreciate anything at all that people might be willing to send my way.

You were correct there is another mod overwriting those changes. It's East Asian Namelist Improvement.

Then you have another mod overwriting those cultures.

Neither Korean nor Hakka has sinosphere as a cultural trait despite the file MoG_DS_K_cultures saying they should have.

Interesting, I'll put this on my list to sort out, but it'll probably be sometime in May

There are no Sino pops in my country, however I can create Sino pops in other countries by using your subject interaction mod to force others to adopt my primary culture which converts a coupl percent of their population to my primary culture including Sino. Howver I recall from an earlier game as Japan where I encountered the same problem while never converting a country's culture. So the problem seems to me to exist independently of this.

The latter point is intended - if you get cosmopolitanism then you no longer need the decision.

Those cultures shouldn't be generating characters though... Are you getting pops of Sino culture? The game, by default, shouldn't generate characters with 0 pops of that culture existing.

When I run this mod as Japan and complete the decision to unify with the Chinese a bunch of bugs seem to appear mostly because the game starts generating characters which are of Sino culture. A culture that only has a single first and last name "No see this name" making this mod incompatible with for example BPM which uses a countries primary culture when assigning ministers. Not that it matters much because I have seen several generals, admirals and agitators of this culture, all with the same name.

Also the decision to integrate the Chinese cultures requires specifically Cultural exclusion, meaning that if you get Cosmopolitanism before that you can't enact the decision.

No update required for 1.8. Confirmed ok.

Updated so that cultures changed to Confusion are correctly reflected in this mod.

I would have to look at where they fit into things, I suspect another trait would be required and I'd have to use the approach I did with Vietnam having the theoretical Yamato accepted culture so that I don't have China accepting the entire steppe - but yes I would consider that.

If you would like to propose any specific details that you think should be used for it then I can look into it quicker. :)

Would you ever consider adding/creating a separate mod for regional cultures - So for example, I'm playing as China (forming the People's Republic) and I want to have like Mongols and Uighurs to be accepted for example without going multiculturalism.

It works by adding a new primary culture to Dai Nam/Japan that has no pops. This hypothetical primary culture has the same heritage trait as their existing one, but the relevant cultural trait to be able to accept the other group.
Manchu doesn't get the decision, though Japan can get the decision by owning Manchu lands.

From the updated description:
"with Cultural Exclusion law and Pan-Nationalism researched."

Cool! What's the combo?

@Miku Moments
I have added a way for the Japanese to feel included in this now.
Requires a law + tech combo to enact the decision.

Hi @Miku, I thought about Japanese but there were some strenuous arguments put against it.
I'm planning on looking into making a decision for Japan to add the trait mid-game if Japan manages to get to Cultural Acceptance + a social tech (tbd). I'm also considering a second decision for Dai Nam to be able to "willingly embrace" by adding the trait to the Japanese if Dai Nam conquers Japan or something as an alternative way of doing it.
I won't be adding it just default to this mod though.
If I run into too many issues making it work with a decision I'll make a duplicate of this that separately adds it to Japanese.

@ab128 it doesn't directly edit anything that should affect clothing - so if you're getting that either the clothing is tied to the sinosphere trait (which should show up in Vietnam too), or you've got a bug/interaction with another mod happening.

It makes korean characters wear chinese clothes instead of korean, is there some way to fix this?

Hi! Could you possibly add Japanese to this? I know this is a little... questionable, but I would just like to be able to accept the Manchu playing as Japan. Plus, I don't think it's too much of a stretch considering Japan has so much Chinese influence in its culture, kanji being one of the absolute largest.

Korean and the Chinese ethnicities are already accepted on account of their East Asian heritage, so I really don't feel like as far the game logic goes, accepting Manchu isn't really a stretch. It has historical backing in Manchukuo as well (also kind of questionable, but for RP reasons I think it works).

Thanks!