I wish this would work with candles as well

Люблю АлиночкуХвощ(и немного ксенофила)

it's finally fixed! tysm brother 🙏

oh btw i forgot to mention that i won't be able to message on discord (it's banned in my country lol)

@ProstoNekit https://discord.gg/FvXFJfSNBE

ok i was able to record it, where can i send the vid?

@ProstoNekit I've not been able to reproduce that yet. It sounds like it's an issue with flickering where it's not being multiplied by the BrightnessOffset from the config, though I can't think of a reason that calculation wouldn't work.

btw i thick it ""might"" be happening only near other light sources, relics, pylons, campfires

like they sometimes become really bright for half a second

it is fixed but for some reason tiki torches sometimes flicker with fullbrightness
i've tried disabling/enabling torch flickering, changing torch brightness

it is fixed!
hopefully for everything

Alright, I was able to reproduce and fix part of the issue. I made an oversight with calculating tiki torch brightness while flickering was off, resulting in it being fullbright. Do tell me if this fully fixed it :)

yeah, the torches are still max brightness. when I said that it was similar to "mass illumination" from Dragonlens, i mean that theres a circle around every light source "its range" and inside of the circle is max brightness. It doesnt make the ENTIRE screen bright.

nope, didn't help

@ProstoNekit released a patch, if this doesn't fix it then I'll patch it again with the old code.

disabled all other mods, nothing changed

@ProstoNekit @ScorchedMango if you two would like to help test further, try disabling every other mod and see if the issue persists; I can rule out cross-mod incompatibilities that way.

I can release a patch with the prior code, but I'd really like to understand what the issue is from first. I still can't recreate the issue, and a developer I work with also can't recreate it.

There's a possibility that the new calculations it's running in stead of an if-else chain aren't being run properly on some devices?

I especially see no reason why this mod should affect *all* lights, it should only affect the lighting of Tiles_4 (torches), and furthermore only on certain frames.

After the last update, all of my lights made my whole screen bright and it acts like the "mass illumination" from DragonLens mod. It seems like whenever you place a torch, it makes everything max brightness in its range. There are no longer any shadows.

i always had it set on a max setting, but changing the number doesn't affect anything
the problem appears only on surface, ground blocks are really bright
i'm on windows 11

@ProstoNekit could you check that your torch brightness settings aren't on a weirdly high number or something like that? I haven't noticed any difference. Tested both with and without Fancy Lighting.

I did make some slight changes to the smoothness of torch flickering but that's a nearly unnoticeable difference.

Are you on a non-windows device?

after last update everything is too bright

you should make this work with candles, candelabras, chandeliers

For those wondering if it works with Fancy Lighting, it does! Although you might need to restart the game a couple times as the first time I tried this turning the Fancy Lighting settings to high makes everything invisible and Ultra just results in a flashbang. :>

I wish we could tweak the rate of the flickering

Does this work with Fancy Lighting? like have the light flickering thing

i don't know if its a problem with the mod implementation itself or just due to how the lighting works in terraria but the subtle flicker absolutely NUKES performance in late-game infernum bosses such as exo mechs. i disabled it out of curiosity after seeing the "light map" debug in the nitrate mod and was like--"does terraria lighting have damage tracking (unchanged areas don't need to be re-rendered every frame) for lighting or something? what happens if i disable the torch flickering? will i get better performance?" YES!! YOU WILL!! huge performance disclaimer for this mod. it caused me so much headaches

its cool ig

Can this work together with the Fancy Lighting mod?

имбо

thank you!

This mod is incredibly indispensable, but the effect does not apply to bonfires currently

@teatheard Do torches flicker in vanilla? A simple yes or no will suffice.

torches already have an orange tint this mod is basically filling a jug of milk with more milk and calling it an upgrade

Kaleb, learn grammar before you try and tell someone how to develop their mod.

mk
its Ben a couple of weeks
so i think its safe to say this

can you pleas update it for other torches please i love this mod but it's just disappointing that only basic torches flicker but not the biome and crystal torches

good

Kinda cool, but very distracting and annoying after awhile. Just doesn't suit a game like this

Ta okey

is this mod compatible with lights and shadows?

why must it bu basic torches flicker but all the rest don't

its sad

@Infernal Delight never spoken truer words

Why not just pool your mod(s) with the Terraria overhaul guys? ... Why are people so agnostic to working together. If variety is the reason, collaboration is the answer... we're worried about a.i.? Hah!

but i don't understand whats the update for ???

@jakeg2275 you and me both

can we get this mod on 1.4.4 its so nice

fps decreasing faster than my life playing terraria

update?

sexy

very nice