Thank you, that explains why it wasn't faster, rather than a bug or conflict

@Blackcat12951 - Pollution cleanup appears to use General Labor Speed rather than Cleaning Speed and thus is not affected by this mod.

Does this affect pollution clean up speed?

@LoopKat Thanks for the tip, I'll take a look on that

@Aelanna I'll pay attention to that, with the new 1.6 optimization update I also think most of those mods will be obsolete, thanks again!

@Aelanna I mean, that's a fair disclaimer, though that's also why I offered JobsLimitsTweak as the primary recommendation because that seemed to be more specific to their particular issue. And, it's always good practice to read a mod's description and skim through comments to see what sort of issues people may be experiencing

Personally, I've got 398 mods in my modlist and haven't noticed any conflicts between the performance mods that I recommended, but mileage will likely vary, especially whenever a new game version actually drops (I stayed on 1.4 for probably a year after 1.5's release just to see how many mods would be updated/continued/deprecated). Most of my mods are simpler tweaks/add-ons such as quality of life, textures, weapons, walls, animals, etc. as opposed to mods that overhaul the game in a more significant way, such as Combat Extended or Medieval Overhaul, so performance mods probably run into fewer issues in a setup like mine

@LoopKat @Citizen706 - As mentioned previously, this mod does very little to the actual function of cleaning other than adding two additional StatParts to the vanilla CleaningSpeed StatDef. However, I just want to point out that blanket-recommending performance-enhancing mods often does more harm than good as every single one of those mods functions by altering the behavior of the vanilla game and thus potentially introducing compatibility issues themselves. RocketMan in particular has an inactive author and most of its functions have been obsoleted by changes in 1.6, so it's unlikely to be updated. Performance Analyzer is also a dev-oriented tool and liable to introduce even more issues than the others if misused.

@Citizen706 Try the mod "JobsLimitsTweak" and see if that helps at all. There's a behavior in Rimworld where pawns who try to do more than 10 jobs in one second experience major issues. Usually the pawn just becomes unresponsive, but in cases where their stats are very high, it can cause major lag too

Otherwise, make sure you're stocked up on the usual performance mods: Performance Fish + Fishery database (from github, not the Workshop), RocketMan, Dubs Performance Analyzer, and Performance Optimizer

Thanks for replying. After running some tests I also think so but I don't know which mod could interfere.

The two things I think could be is either the very high workspeed of my colonists or the Pick up and Haul mod.

I'm not a good modder so I'm not sure.

@Citizen706 - I just ran a test myself with over 100 colonists and flood-filling the entire map with filth and there was barely any bump in game performance (approximately 2.3ms/tick to 2.5ms/tick, which rapidly went down as the filth was actually cleaned up). This sounds more like a mod compatibility issue than anything that this mod is doing, which is simply adding two stat parts to the vanilla Cleaning Speed stat via a simple XML patch. If you can help narrow down which mod might be causing the slowdown then I can take a look and see if there's anything that can be done about it, but otherwise there's not much for me to go on.

Hello, dude! I tested out your mod on 1.6 with a colony with 50+ pawns, 40+ animals and let the colony get VERY dirty.

I noticed that performance drops by like 95% when cleaning the mess.

My pawns have extremely high workspeed (I'm using a personal mod that alters the stats of the pawns to be absolutely OP), I don't know if that's the root of the problem but I appreciate if you could take a look.

On the debug log there's nothing popping up but the lag is visible.

Thanks!

Ok, ill ask them

@nikita150u - Cleaning Speed is a vanilla stat since 1.4 and thus all this mod is doing is making said stat affected by capacities and adding the two new traits. If Common Sense's custom job isn't taking Cleaning Speed into account, then they need to fix it on their side. :)

Can you make patch for Common sense? Cause seems like its adding own cleaning job which extremely long and not affected by this mod

@Stellar Harbour - Nothing has changed in 1.5: the vanilla StatDef is identical to 1.4, and this mod merely adds the appropriate StatParts, enables it for human colonists, and adds the two related traits.

What about 1.5? Any changes?

great

@happyBirthday - This seems highly unlikely, especially considering that Cleaning Speed is a vanilla StatDef in 1.4 and this mod merely adds two traits and modifies the way that that stat is calculated. Can you provide a log?

I think this mod has incompatibility with CleaningArea

Does this apply to biotech's pollution cleaning?

Awful idea:
Crossover between this and Vanilla Skills Expanded where characters with the fastidious trait get access to a special skill for increasing their cleaning speed over time.

Had to remove and resubscribe, but seems to be solved now. Thank you!

I pushed an update that should hopefully fix this issue, please let me know if it continues to happen. Apologies for the inconvenience!

https://drive.google [DOT]com/file/d/1zqc85b8Tmn9w6YD3-KGKZJ6O4K88bNEf/view?usp=sharing
https://drive.google [DOT]com/file/d/1WgefqfVjvXG9_8uEc3hGiIoJOvXWx5l9/view?usp=sharing
Even hovering over trait to see description shows error
Can you upload previous version somewhere to use as a local copy until everything’s been fixed.

Yeah, last update definitely broke something.
{链接已删除}https://drive.google.com/file/d/1zqc85b8Tmn9w6YD3-KGKZJ6O4K88bNEf/view?usp=sharing
{链接已删除}https://drive.google.com/file/d/1WgefqfVjvXG9_8uEc3hGiIoJOvXWx5l9/view?usp=sharing

I'm getting these error messages running RImWorld 1.3

Could not resolve cross-reference: No RimWorld.StatDef named CleaningSpeed found to give to RimWorld.StatModifier (null stat)

Failed to find RimWorld.StatDef named CleaningSpeed. There are 232 defs of this type loaded.

It appears that this mod has issues when it comes to mods that add entities that also clean, but aren't pawns, and so, don't technically have the relevant skills.

Things like RimFactory's drones, or MiscRobots++'s bots appear to simply freeze when cleaning, with no indicated progress, until the task times out.

Happy to see that you have started to update your mods. I consider your mods a must have for any serious play and once Biotech releases later this month it would be nice to have them ready.

Hmm, almost certainly a my-side thing then. I'll fix it up when I start my next playthrough which should be soon enough. Thanks for the support, I'll let you know if I can't fix it for some reason!

@Tomoko - I just double checked mod functionality on both 1.3 and 1.4 and both cleaning and the cleaning traits seem to be working fine. The only time I encountered anything remotely close to what you're describing is when I was running the old version of the mod against the unstable branch, before it was updated. You can force-update your local copy of the mod by unsubscribing and resubscribing to it; outside of that, I have no idea what could be wrong. :\

No error at all. The "Fastidious" trait reads "Error getting tip text." and whenever my workers go to clean, they just afk next to dirty areas with the current job of "Standing".

Removing the mod and reloading seems to fix it entirely, but I haven't tried adding it back or loading other saves.

@Tomoko - I just double checked and the updated version from this morning appears to still be working fine under 1.3. Are you getting any kind of error message? I don't have much to go on here.

I haven't switched to any betas and I didn't have to download anything, so I'm assuming still 1.3

@Tomoko - Are you playing on the new unstable branch or 1.3 still?

This seems to be broken as of the most recent update? Unsure if this is a my-side exclusive thing or just the latest update breaking it.

I didn't even realise I got a new update, I just had to accept a new EULA and now this mod, specifically, is broken.

@Pearific - I honestly have no idea, Cleaning Speed is a very small mod that does a very targeted patch, compatibility depends on whether Cleaning Limbs is trying to patch the same internal method that I am. Best way to find out is to just try it and see what happens. :)

Is this compatible with "Cleaning Limbs"? https://psteamcommunity.yuanyoumao.com/sharedfiles/filedetails/?id=2673504697

simple and lore friendly mod like this should be added to base game

great mod

Where's the representation for my ADHD self where my cleaning speed is 200% but the amount of things removed is only 50%?

Great mod!

Ah, I see. I didn't know that mod, I thought you were suggesting to remove it when it appears, now I see that it does just what I wanted. Thank you!

@Javiervs - As I mentioned just a few posts down from yours, the easiest way to pick and choose traits are to either use Vanilla Traits Expanded (which lets you disable any and all traits, even from other mods) or Cherry Picker. Hope that helps!

Hi. I like that cleaning speed is affected by workspeed and health, but I'm not fond of the two new traits. Is there a way to turn them off so that they don't appear?

Thanks

This mod is cool but when a pawn has EXTREMELY high stats the game runs like 1 fps when the pawn is cleaning, I won't continue to use this but its a cool mod

@bugrilyus - Hi! If you would like to remove the traits, I would recommend using Cherry Picker or Vanilla Traits Expanded , which gives you full control over which traits you want to use. :)

can we turn of those traits?

https://www.youtube.com/watch?v=1LjgtdN-0Ho Your mod is on youtube. Countless will now know the joy of quick sanitation.

From youtube, this is really a good mod

I came into the workshop page to decrease my mods for better loading speed....

it didn't work XD

Haha awesome

Did Someone say vacuum cleaner?
https://psteamcommunity.yuanyoumao.com/sharedfiles/filedetails/?edit=true&id=2751783180