Blade sometimes can't attack enemies if there are Obstacles between us, and I'm not sure why this happens. In addition, I feel it's unfair that Blade can't collect pickups like Spirit Sword and The Forgotten, hope you could tweak it.

引用自 yuqingzhitian：

Blade sometimes can't attack enemies if there are Obstacles between us, and I'm not sure why this happens. In addition, I feel it's unfair that Blade can't collect pickups like Spirit Sword and The Forgotten, hope you could tweak it.

When the blade tries to damage an enemy it does a line-of-sight check. This check is only done for non-flying enemies. I might try to make this check more forgiving. Either way, I'll add an option to completely ignore line-of-sight through the mod config menu.

The item pickup idea is good, I'll see what I can do about it.

Edit: I've sent the changes. Both requests are also added as options to the mod config menu.

Hey, your "ENTITY_TAKE_DMG" function, and related SamuraiBladeEntityDamage function, both have the capability to "return true" in the "ENTITY_TAKE_DMG" callback.

At the moment, a function returning non-nil will cause any code from other mods for the same callback to get skipped entirely. So you should only ever return false (if you want to stop damage) or don't return anything at all / "return nil"

I know you use typescript so hopefully the description of the issue still makes sense. Would appreciate it if you could fix this to avoid sometimes causing problems with other mods.

Thanks!

引用自 Ghostbroster Connor：

Hey, your "ENTITY_TAKE_DMG" function, and related SamuraiBladeEntityDamage function, both have the capability to "return true" in the "ENTITY_TAKE_DMG" callback.

At the moment, a function returning non-nil will cause any code from other mods for the same callback to get skipped entirely. So you should only ever return false (if you want to stop damage) or don't return anything at all / "return nil"

I know you use typescript so hopefully the description of the issue still makes sense. Would appreciate it if you could fix this to avoid sometimes causing problems with other mods.

Thanks!

Oh wow, I had no idea. I guess I should've read the docs more carefully, thanks for the heads-up. I'll send a fix right away.

No worries! Thank you!

after this game update the sword no longer appears at the beginning

Yeah there was a bug in an isaac patch but thankfully they hotfixed it and things are fine now

after this game update the sword no longer appears at the beginning

引用自 Chimas_Boy：

after this game update the sword no longer appears at the beginning

引用自 lks_ke：

after this game update the sword no longer appears at the beginning

Item not being spawned in the starting room is intentional. I am trying to slowly pull the mod out of 'beta' so I've set it to be disabled by default.

You can still enable the item being spawned in the starting room through the mod config menu. Look for the option 'Spawn In The Starting Room' and set it to 'true'.

it doesnt show up, i attack and nothing happens

I got the item as T judas and it prevented me from attacking period, I don't know if it's on my end or not but I couldn't use it :(

glad im not the only one, no matter what i do it cannot spawn in the room, 2nd it will never attack

引用自 chazeracer：

glad im not the only one, no matter what i do it cannot spawn in the room, 2nd it will never attack

Sounds like a mod conflict. I honestly can't do much without the log file, I've tried to replicate this issue multiple times before with different setups and I couldn't get it to happen.

I'd appreciate it if you pass me the log file. Also, have you tried using mod config menu options to spawn the item at the start? And try to change the Tear-Behavior from the config menu as well, I suspect not firing might be related to that option.

引用自 Math-Man：

引用自 chazeracer：

glad im not the only one, no matter what i do it cannot spawn in the room, 2nd it will never attack

Sounds like a mod conflict. I honestly can't do much without the log file, I've tried to replicate this issue multiple times before with different setups and I couldn't get it to happen.

I'd appreciate it if you pass me the log file. Also, have you tried using mod config menu options to spawn the item at the start? And try to change the Tear-Behavior from the config menu as well, I suspect not firing might be related to that option.

yeah i fixed it haha. sorry!!

引用自 chazeracer：

引用自 Math-Man：

Sounds like a mod conflict. I honestly can't do much without the log file, I've tried to replicate this issue multiple times before with different setups and I couldn't get it to happen.

I'd appreciate it if you pass me the log file. Also, have you tried using mod config menu options to spawn the item at the start? And try to change the Tear-Behavior from the config menu as well, I suspect not firing might be related to that option.

yeah i fixed it haha. sorry!!

Awesome, thanks for letting me know