Uploaded the fixed 1.1 version to steam and will try to keep it updated.
https://psteamcommunity.yuanyoumao.com/sharedfiles/filedetails/?id=2071681396
Hope this helps anyone!

When you add someone as a contributor you can tweak what they're allowed todo including updates etc.

Hi everyone, I just saw these comments and I just want to add, since I don't see me maintaining this any longer, I would be totally happy if anyone put up the new code on the workshop, hit me up and I will mark this ans invisible/deprecated and/or link to your submission.

Also big thanks @jtgibson, I really appreciate that you stepped up to this. I would be happy to add you as a contributor if you want (I /think/hope/ that would allow you to push updates yourself but I actually don't know too much about the steam workshop so ¯\_(ツ)_/¯)

1.1 build is now up there, too! I have less than zero inclination to upload to Steam Workshop -- my sole interaction with the WS is to download, rename, and copy loose into the Mods folder of my Ludeon/SendOwl copy -- and I don't want to step on the author's toes any more than I already have.

@_hmm: You have unlimited and full permission to take any content added in my fork, without credit. All contributions I have made are covered by the original MIT licence and can be considered to be as permissive as the public domain.

If anyone else wants to upload my fork in their own name, be my guest, but link to this page and give due credit to the original author, please!

Cheers!

Okeydokey! Looks like everything is more or less ready to roll. I'm going to have to upgrade to 1.1 to push a 1.1 build too (which I am *not* looking forward to; I'm running over 400 mods on 1.0!), but the 1.0 build is done and available for anyone at https://github.com/jtgibson01/RimWorld-Signs_and_Memorials/

Verified fixed the crash-on-load, while still retaining the mod settings (and sneaking in one more as a thank you for the mod... =)). Slipped in a French translation too because why the heck not, I had to translate some new mod settings anyway.

Still running a few last tests on the save-load routine, and I switched over to RimWorld's built-in zlib CompressUtility compression on it, since it was nearly tripling the saved bytes for a decent-sized memorial (590 bytes of base-64-encoded UTF-16 versus 221 bytes of UTF-8 -- the same string now encodes at 264 bytes), but everything seems to be working great now!

I also tweaked the perspective on the memorial, added perspective to the sign, and rastered at higher res so you can actually see that there's printed characters on the memorials and signs (I had no idea until I pulled up your vectors in Inkscape!).

Once I've run a thorough test, I'll try submitting a PR via a Github fork.

Running the old version and having no idea that this was updated, I looked into your pre-September source code and noticed the smoking gun that caused your trouble: rather than saving a static reference to your settings instance (and assigning that reference in your mod settings' constructor), you were instantiating and saving a reference to the mod settings in every single instance of your "SaM.Base" Building (Thing). To put it mildly, that was not quite the way to go about it. =)

I made a few other improvements on a quick pass through the source code, including serialising the saved data to base64 rather than reading/writing directly -- saving raw user-enterable strings makes save/load errors far more likely, especially if the user inadvertently uses a character that the save/load routine can't read. A user writing something like <YES> would also brick a savefile, for instance, since RimWorld would read it as XML.

Sounds like a fun mod. We need a tombstone and wall version of this xD

after some more great feedback there has been another update, which again, may (this time I'm a little more confident, but I know best how that is not a great indicator) fix this issue where saves became impossible to load with this mod enabled. If you had/have that issue simply removing the mod should allow you to load the world, without the stuffs though. Or this update really fixes it and it simply works.

well, just to update everyone here, I did push an update that may or may not fix stuffs

oof, I have to admit that I haven't played rimworld in quite a while, I did some mod testing a while back (see past comments), but it's way on the backburner...

I don't know that I will be able to do much, like I have no idea if there were any changes to rimworld that may apply here, and I don't really have much time to spare. Either way I'm definitely gonna need more info on that, a paste of the log would be super helpful, perhaps even on github instead of here.
It may well be a quick fix, otherwise it will probably mean the end of this mod (for now) unless someone else wants to pick it up.

I'll add that I installed the mod through steam.

Building a memorial causes a complete save corruption for me. Luckily I removing the mod removes the memorial and the save becomes playable once more.

All the time you need, man; no use pushing a buggy mod

Alright, I will see what I can do when I get to it, it seems feasible and useful, just need to find some time. Maybe I can borrow some inspiration/guidance from the mods you've given as examples... Still can't give an ETA though, hopefully sometime this summer...

@Manuel
You might take a look at how @Murmur implemented his Wall Lights mod:
https://psteamcommunity.yuanyoumao.com/sharedfiles/filedetails/?id=1423699208
Whether that method is compatible with yours or not, maybe worth a look?

No probs - recommend taking a look at the way Dubwise does his coolers - they can be placed on the same wall tile as an adjacent object, suspect its a simple Def config. Best of luck

Hmm, I mean, I think it would be possible to put a sign on top of a wall entity... Though I currently don't have the time to implement something like that. It's not a bad idea, though it might be a bit much to maintain compatibility with other mods. I might see what I can do in future but nothing concrete right now...

Do you think there'd be a chance of getting wall signs, or are you done with this now?

Okay that is wild... I don't get any error, but I have another idea... I've been doing all debugging and testing on Linux, assuming that C# will do its part...
This will take me a bit but I will try to look into this whole thing on Windows again, because there must be something I'm missing, since I have no issues with your world... Again, I'll have to set up some things but I hope to get this figured out soon...

Alright, I'll give that another shot, thanks very much ^^

It does seem however that the mod behaves a bit differently based on how it is installed. When simply downloaded through steam it does cause this issue at all times. If installed manually in the Mods directory along with Core, it seems to not be affected at first, but it can, at random, corrupt the save again. I have no idea why and it puzzles me a lot.

I have reproduced the issue. Both the test save and an output_log file are in the archive below (if the link is not removed again):

https://mega nz/#!Us9zBabA!9az5_tFgH8o6CmEsqd_9vfj01RUcM-0VE1jCGG_ZPe8

Hmm, so I don't know if I quite understand what you mean by updating the mod list...
So for testing, I've tried adding and removing different mods and moving the positions but so far I've not encountered an issue... Obviously when you remove this mod with memorials placed in the world, it will throw an error, but the world will still load, they will just be removed in the process.

It might help if someone with this issue could provide a corrupted save, or the full log error...

Hmm, thanks for the detailed description, I'll have a look

To anyone who has a corrupted save: don't worry, it's salvagable. You simply need to open the save in any text editor and manually remove sings/memorials created on that save and it will load (without those memorials of course but there is a price to everything). You're looking for all <thing> which have SaM.Base within the definition.

Also the issue with broken saves seems to be in some way related to changing the list of loaded mods as I've tested myself.

@Manuel, if you're still doing anything related to this mod, could you please look into it? To reproduce the problem simply create a new world, make a sign or memorial there, save, then update mod list and try to load that save. It should be corrupted and generate a NullPointerException in the log file in main Rimworld directory.

No, this mod contains nothing where I would say that it could cause problems with other mods

Any hard incompatibilities

@Manuel
!

Alright, took a bit longer 'cause real life is busy, but I finally got to it. Turns out some defs were renamed but now it's compatible with B19 as well ^^

I can't wait! :D Immersive and very... it's life itself. For me - neccessary as hell :). Adding to game tart flavour and inclining to thoughts (at least me : P) still waitin' for 0,19 version :) Goodluck ^^

It should be, yes, but I can go look at it over the weekend. I will probably just change the version number.

is this mod ok for B19

And this is why these comments are a really bad way of reporting issues, there is simply no way of responding properly. So please, if you ever find an issue with this mod (or any other mod at that) head over to GitHub or the forums, it really helps if users report issues.

Are you sure it's this mod, it should be very stable, maybe there is some odd interaction with another mod? I would appreciate if you could provide logs and a mod list so I can try to find the issue.

This mod corrupted a few of my saved games. Just a warning to everyone.

Just don't try to remove it from a save without deleting ALL the signs and memorials you made.

Yeah, it doesn't have any changes to the base game so it shouldn't cause any issues when added to an existing save file.

Hey! Great! Have been looking for something like this for a while. Is it save safe? As in I don't have to start a new game, I mean?

great mod. gave it a positive rating :)

I love this mod! It adds a feature I've been wanting forEVER, and whenever I would request it people would just say "quit being lazy and use a pen and paper!" But for many, many reasons, this mod is better than just scribbling it down. With your mod, I can easily change the order of what I type, not worry about my notes getting lost, not worry about how to organize them, etc. Thank you tons for this. I also really appreciate that you are listening to commenters' concerns about balance issues! This mod will get the best possible rating from me.

Ah darn, I totally forgot to properly set the beauty stat... And I didn't really consider the building cost either, I'll go tweak it a bit...

Pushing an update in a bit!

dude what the heck is with your stats? it costs more to build a sign or a memorial than it does to build a wall and they're ridiculously beautiful...

I've wanted to do this SO MANY times and now I can.

This is a feature I've been wanting for a long time! I can't wait to see how it works out!! :)