@Starempire42 Up to you hun, though since there is overlap I'd pick one.

Question should I run this mod or yours?

(mod in question: https://psteamcommunity.yuanyoumao.com/sharedfiles/filedetails/?id=3528330887&searchtext=VAE)

Pushed and update that changed the Package ID, if you are using this mod you'll need to re-enable the mod next time you start up Rimworld, sorry for the inconvenience!

Yeah that was a mistake, I wanted to change the package ID so people didn't have to unsub to the old one. I will probably change it soon-ish.

Ah, while you're here - I had something else I spotted, but that might be in fact a bit hard to change after the fact. Having your packageID as 'vanillaexpanded.reupdooted' might be... quite a bit misleading. I know, it was basically copied from the og version, but that really sounds like a bad idea. Worst case people who only read the packageID (as it happens when troubleshooting via a Player.log only) might thing this is an official VE-mod and report issues to them.

As said, no good solution now that it's done - but just something to keep in mind. Changing the packageID technically still is an option of course, the mod is still new and not many other mods (like mine) will probably patch it - so... if you decide to change it, you might want to do so as soon as possible. Might cause hiccups with ppls modlists though, since the game wouldn't load the mod for people until they add it to their list again.

Thanks for highlighting those Tide, I take care of those issues in the coming days.

Also; the VE Framework dependency seems to be completely unnecessary/redundant. VArmourE is already dependent on it, so this just doubles for no good reason. Not a real issue, but without going into the specifics - this can at times cause minor issues with some external mod-managers.

A rule of thumb, when it comes to dependencies & loadorder-rules is to provide what is needed, but also only the absolute necessary. That will reduce fringe cases that can lead to logic-loops and similar.

Was running into a small oversight while adding the mod to be patched from my mod's end:

> Could not resolve cross-reference: No Verse.ResearchProjectDef named CataphractArmor found to give to Verse.RecipeMakerProperties

Simply speaking, right now the recipe for the Cataphract (and potentially other) items is loaded no matter if the user has the DLC active or not. You either want to put the whole Def into a 'MayRequire' (to only load when the resp. DLC is found) or - ideally even - want to put those optional items into their own Def-file and use loadFolders to only load them when the necessary DLC is active on the user's modlist.

@Author, Whether you keep it up or not is up to you, I'll update it to 1.6 (and newer) eventually. Maybe a week or month from now, I am currently remaking some of the older gloves, and especially boots, and merging all the artwork scattered about into one, more comprehensive file assortment. Good luck with whatever you plan on next.

@bunx2021 It was both easier and harder then I thought. Either way if you get back into the swing of things and updated your own and want me to private this mod all you have to is ask, I did this as a service to the community and edu-mah-cate myself along the way!

@Author, funny thing, Uploading the mod first time was actually harder than the .XML itself(prior to that I made a unreleased addon for vanilla weapons expanded, so not a lot of experience.)

It's the first time I had to socialize over on discord with actual developers to learn the process T-T
Good job tho 👍

@bunx2021 I'm honored you think so! I mostly wanted to help curb the endless flood of '1.6 PLZZ!!' spammers and actually learn to upload a mod to the workshop.

I guess I could've taken the 1% work to rewrite the version list to include 1.6. Afaik it mine still works fine, But you atleast gave it a nicer Thumbnail 👍Salute 🖐

Good 🍺

ba na na

banana

I am a very silly modder!

banana