@Mesez ~ That damn patch keeps showing up in bug reports. I think I need to rewrite it or something >.< Appreciate you reporting that, and that you mentioned what mod it's conflicting with, I'll take a look at it when I can

this is a UI crash inside MultiDoctorSurgery’s assign-doctors dialog. The null happens while drawing the window (Dialog_AssignDoctors.DoWindowContents), and two global transpilers are in the mix:

Visual Exceptions (the Harmony “ExceptionsAndActivatorHandler”)

TDS Bug Fixes (FixWindowDragInsteadOfReorderable), which patches Verse.Window.InnerWindowOnGUI

if its after an hour or two of play time, then that sounds like memory leaking. @ThatGuyGW, what did your ram do when you had this issue? increaingly slowly?

@ThatGuyGW ~ Oooo, look at that, a mod list with a bug report <3 I'll take a look when I get a chance

@Meme_Goddess Also reporting a performance issue, spent a few hours tearing down list one by one and removing this mod from list (And consequently also Find Lib and Everybody Gets One) allows me to run at consistent 12x speed with Smart Speed, otherwise I was struggling to get a consistent 2x speed after an hour or two of playtime.

https://pastebin.com/Mjgk1nYk

@Geojak ~ Unable to replicate this performance issue. Does the issue happen with just this mod loaded? Thinking it might be a conflict, and that I'd need a mod list from you to check it

i dont know what that trasnpiler was supposed to do, but it was too costly, and it doesnt seem needed for "everbody gets one" which is an awesome mod that needs this here

i got me the code from github and simply deleted that transpiler file from the mod and rebuild. 1.4 ms per Frame better according to ubs performance logger

the transpiler for InnerWindowOnGui, fix Window for Drag instead of Reorerable causes significant performance losses and TPS. I dont know what it does, but can you remove that. Its 15 times worse than my next most performance degrading mod. its rly rly big.

@rk ~ Nothing yet, haven't had much time to look into it. I'm guessing you're experiencing the same issue though?

Any progress on the issue greensniperhat reported? I'd like to try this mod but I use Reunion

@Retagin ~ Interesting, what is this mod that is causing the conflict? And does it happen with just that mod and this one?

@greensniperhat ~ Hmmm ok, such an edgecase thing, will be difficult to replicate. I'll take a look at it though

- POSTFIX dimonsever000.socialinterface: Void SocialInterface.SocialCardUtility_DrawRelationsAndOpinions_SocialInterfacePatch:Postfix(Rect rect, Pawn selPawnForSocialInfo)
at Verse.StartingPawnUtility.DrawPortraitArea (UnityEngine.Rect rect, System.Int32 pawnIndex, System.Boolean renderClothes, System.Boolean renderHeadgear) [0x00244] in <cb53cd4422904947932d33f561ad8d15>:0
- POSTFIX kyrun.mod.reunion: Void Kyrun.Reunion.HarmonyPatches+StartingPawnUtility_DrawPortraitArea:Postfix(Rect rect, Int32& pawnIndex, Boolean& renderClothes, Boolean& renderHeadgear)
at RimWorld.Page_ConfigureStartingPawns.DoWindowContents (UnityEngine.Rect rect) [0x001e5] in <cb53cd4422904947932d33f561ad8d15>:0
at Verse.Window.InnerWindowOnGUI (System.Int32 x) [0x001d3] in <cb53cd4422904947932d33f561ad8d15>:0
- TRANSPILER Uuugggg.rimworld.TDS_Bug_Fixes.main: IEnumerable`1 TDS_Bug_Fixes.FixWindowDragInsteadOfReorderable:Transpiler(IEnumerable`1 instructions)

Might be a conflict with Reunion, when generating pawns it sometimes makes the 'best stat' panel below the pawn info disappear, as well as the Reunion set ally thing. I've noticed this happens when a genned pawn has a relationship.

Exception filling window for RimWorld.Page_ConfigureStartingPawns: System.NullReferenceException: Object reference not set to an instance of an object
[Ref A2600A5C]
at RimWorld.SocialCardUtility.RomanceOptions (Verse.Pawn romancer) [0x00012] in <cb53cd4422904947932d33f561ad8d15>:0
at RimWorld.SocialCardUtility.DrawTryRomance (UnityEngine.Rect buttonRect, Verse.Pawn pawn) [0x00027] in <cb53cd4422904947932d33f561ad8d15>:0
at RimWorld.SocialCardUtility.DrawRelationsAndOpinions (UnityEngine.Rect rect, Verse.Pawn selPawnForSocialInfo) [0x001dc] in <cb53cd4422904947932d33f561ad8d15>:0
(cont)

Mod seems to work so long as there are not any mods that add starting scenarios. If any mod adds a starting scenario no starting scenario can be selected, and dev quickstart fails. hugslib spits this out, this is the only page_selectscenario exception:

Exception filling window for RimWorld.Page_SelectScenario: System.NullReferenceException: Object reference not set to an instance of an object
[Ref 8EF1264F]
at Verse.GenTypes.SameOrSubclassOf (System.Type baseType, System.Type parentType) [0x00009] in <cb53cd4422904947932d33f561ad8d15>:0
at Verse.GenTypes.SameOrSubclassOf[T] (System.Type baseType) [0x00000] in <cb53cd4422904947932d33f561ad8d15>:0
at RimWorld.ReadingPolicyDatabase.GenerateStartingPolicies () [0x0003e] in <cb53cd4422904947932d33f561ad8d15>:0
<0x24bcb34c0e0 + 0x0007a> <unknown method>
<0x24bcb342730 + 0x006ea> <unknown method>
...

...
at RimWorld.Page_SelectScenario.BeginScenarioConfiguration (RimWorld.Scenario scen, RimWorld.Page originPage) [0x00005] in <cb53cd4422904947932d33f561ad8d15>:0
at RimWorld.Page_SelectScenario.CanDoNext () [0x00014] in <cb53cd4422904947932d33f561ad8d15>:0
at RimWorld.Page.DoBottomButtons (UnityEngine.Rect rect, System.String nextLabel, System.String midLabel, System.Action midAct, System.Boolean showNext, System.Boolean doNextOnKeypress) [0x000f2] in <cb53cd4422904947932d33f561ad8d15>:0
at RimWorld.Page_SelectScenario.DoWindowContents (UnityEngine.Rect rect) [0x000ab] in <cb53cd4422904947932d33f561ad8d15>:0
at Verse.Window.InnerWindowOnGUI (System.Int32 x) [0x001d3] in <cb53cd4422904947932d33f561ad8d15>:0
- TRANSPILER Uuugggg.rimworld.TDS_Bug_Fixes.main: IEnumerable`1 TDS_Bug_Fixes.FixWindowDragInsteadOfReorderable:Transpiler(IEnumerable`1 instructions)

I have a large modlist, it was easier to remove it. Unfortunately, don't have that much free time to hunt the cause of the problem. Hope the log shows something. It was RimSorted, all major errors caused by other mods smashed down. I try not to use mods that do the same thing or obviously interact with each other.

@2498timmy @Terrestre @тетеря, блин ~ Do those issues happen with just this mod installed? Or with a large modlist?

soon after loading a newly generated map:

Exception filling window for LudeonTK.EditWindow_Log: System.InvalidOperationException: Collection was modified; enumeration operation may not execute.
[Ref 2007F0A6]
at System.Collections.Generic.Queue`1+Enumerator[T].MoveNext () [0x00013] in <51fded79cd284d4d911c5949aff4cb21>:0
at LudeonTK.EditWindow_Log.DoMessagesListing (UnityEngine.Rect listingRect) [0x001f9] in <cb53cd4422904947932d33f561ad8d15>:0
- PREFIX UnlimitedHugs.HugsLib: Boolean
...
at LudeonTK.EditWindow_Log.DoWindowContents (UnityEngine.Rect inRect) [0x0026e] in <cb53cd4422904947932d33f561ad8d15>:0
at Verse.Window.InnerWindowOnGUI (System.Int32 x) [0x001d3] in <cb53cd4422904947932d33f561ad8d15>:0
- TRANSPILER Uuugggg.rimworld.TDS_Bug_Fixes.main : IEnumerable`1 TDS_Bug_Fixes.FixWindowDragInsteadOfReorderable:Transpiler(IEnumerable`1 instructions)

https://gist.github.com/HugsLibRecordKeeper/ff3eb53c01e34d2f6e59fd16d5874dd6

Cant generate new scenario

I am unable to generate new scenario, visual exceptions shows this is preventing the screen progress when clicking next on scenario screen.

Goodnight sweet prince

Thank you!

I appreciate the work and honoring Uuugggg!

o7

o7 - i'm very glad you preserve his legacy. Thank you for that!