not good for B42.12.1 and whoever was reporting issues below

enhances combat peformance, but kills computer peformance.

yeah. no if I attack in close combat with a firearm it generates over a thousand xp gain error messages. and I can't even tell what mod its conflicting with X_X

firearms*

why does this work on weapons????
somehow it's ridiculous that I spend 15 rounds to kill one zombie (if you take a negative perk and there will be 0 level of battle astress)

shooting a gun shouldn't give exp unless it would also work on guns

mod sucks took me 8 days to figure out

ERROR: General , 1755305080335> 12,992,050,331> java.lang.NullPointerException: Cannot invoke "zombie.characters.skills.PerkFactory$Perk.getType()" because "<local6>" is null
ERROR: General , 1755305080335> 12,992,050,331> at zombie.characters.IsoGameCharacter$XP.AddXP(IsoGameCharacter.java:14848)
ERROR: General , 1755305080335> 12,992,050,331> at zombie.network.packets.AddXp.process(AddXp.java:52)
ERROR: General , 1755305080335> 12,992,050,331> at zombie.network.GameServer.receiveAddXp(GameServer.java:1276)
ERROR: General , 1755305080335> 12,992,050,331> at zombie.network.PacketTypes$PacketType.onServerPacket(PacketTypes.java:1022)
ERROR: General , 1755305080335> 12,992,050,331> at zombie.network.GameServer.mainLoopDealWithNetData(GameServer.java:1532)
ERROR: General , 1755305080335> 12,992,050,331> at zombie.network.GameServer.main(GameServer.java:800)

was coming from this mod.

It’s already a beautiful and well-made mod, so I’m definitely not nit-picking — just sharing a couple of small suggestions that might make it even better:

It could be nice to give it a simple, single-word name like “Prowess”, “Brawl”, or “Handling” or "Agile", "Lethal"... a short name would look cleaner in the menu and also feel more in line with the vanilla naming style.

It might also make sense for it to be placed under the Combat category, since that would match its theme and make it easier to find among other related skills.

@GersonRess > You're welcome brother! Thanks to YOU for the mod and for fixing it up!

@CFW Magic Thanks a lot for your contribution. I hadn't noticed it myself. I'll update the mod as soon as I can.

Okay, after testing, I've found the fix. In CombatMasteringSkill.lua, add this code block to the beginning of combatMasteringModify function:

if not handWeapon then
return false
end


This will check if there is a weapon in the player's hands on every execution, and if there isn't one (when weapon breaks) will immediately return out of the function. I've checked and debugged and it seems to be working. Here's the link to the fixed version of the mod so you can see/test it for yourself. It's unlisted and I will remove it when/if you implement the fix:

https://psteamcommunity.yuanyoumao.com/sharedfiles/filedetails/?id=3537039995

Hello there, I'd like to report a bug. When doing multiplayer, every time a weapon breaks there's an error. As far as I can understand it, it's because there's no sanity check (check for null value) in the file client/CombatMasteringSkill.lua. As a result, when weapon breaks, game tries to apply combat mastering while there is no weapon in player's hands.

Hi does restarting the game reset the combat speed of this mod? I realized whenever I reload my save file after a break the hitting speed seems to be much slower.

b41?

Buen mod, le da mas dinámica al combate

в чем смысл мода?

Это отличный мод, давно хотелось что-то такого, спасибо тебе великий автор

great mod is it Evolving Traits World (ETW) compatible?

How can I increase my attack speed?

No, pushing won't be affected, because it only affects weapons.

is it going to affect pushing?

Hey no clue if this was said already but I noticed that despite have 0 mastery, my guy is still swinging normally. Am I missing something or is this just a bit of an error?

hello, i don't know if is a bug but why do i need 30K xp points on level 6?

my pipe-wrench is practically a chainsaw

also re-balancing would be nice to have it scale with some kind of formula off both weapon's level and combat mastery skill rather than just turn every weapon even if you are level 0 into a unbelievably powerful weapon

will there be options for damage modification? assuming its in b41 that is

Working well, thanks for updating 🎉

@GersonRess Do you think you could make a sandbox option that disables the traits added by this mod?

Do you have any sandbox settings?

Brilliant concept!
Just loaded this into an ongoing hosted server and all my players started at Mastery Level 5. Is that normal? I didn't notice anything mentioning it, and was expecting to have to level up from 0. Asking in case there is a mod conflict I should try to hunt down.

@verdugo thanks for the info, I think it should be fixed now for b42

@GersonRess only issue so far is it isn't showing up for 42 other than that it worked great 😊 I have this saved to my favorites so just patiently waiting for it to reappear. Thanks for replying, keep up the good work 😊

@verdugo Thanks bro, if you find any issue feel free to let me know.

@Construct I don't think it fits the idea of this mod, but I appreciate the suggestion

Love this mod

@maboo Yes, it adds XP whenever an attack is made, even with spacebar

Is it normal for experience points to increase when using a gun?

@Anxiety @IEnemY @Lionheart That was a weird issue, but I think its fixed now, let me know if u still facing it

There's clearly an issue with your update. I'm also getting a disk write error when Steam tries to download the update. Using SteamCMD to manually download it in a separate directory returns "ERROR! Download item 3435985650 failed (I/O Operation Failed)" with error codes of 1314 and 4392 (when run as administrator). Your other uploaded mod (workshop item 3374408921) downloads just fine. Something must be wrong with your upload.

@GersonRess can you upload your mod into github?

@Lionheart issue came back for me)

@IEnemY I am also having that same issue. What exactly did you do to fix it?

@IEnemY Glad to hear you managed to fix the issue! And no worries at all, you didn't disturb me. Thanks for your feedback!

@GersonRess sadly, no. Happens on two my devices and also happens for other server clients. Same issue for everyone. But this is CDN issue and I've solved it via VPN, sorry for disturbing you) BTW, awesome mod, nice work!

@iEnemY Hey man, it seems to be an issue with your storage. Do you have enough free space? Maybe your disk is full. Also, check if the workshop mods folder has read and write (RW) permissions.

Hello. Today I can't start server - mod update failed to download.


LOG : General , 1741347648864> 642,620,703> Workshop: download 179392/179392 ID=3435985650
src\common\symlink.cpp (34) : Assertion Failed: Unexpected Error Result 4392
LOG : General , 1741347648916> 642,620,756> Workshop: onItemNotDownloaded itemID=3435985650 result=37
LOG : General , 1741347648917> 642,620,756> Workshop: item state DownloadPending -> Fail ID=3435985650

Same problem for steam client - "Disk write error"

Nice timing. I was just about to mention that, looking at the scripts, it was possible you botched dynamic trait management. So it's cool that you caught that. I had, in fact, reached level 2+ in the skill before it happened each time. I guess I didn't notice I'd lost the Defenseless trait. Anyway, I'm glad you're fixing it (and it probably wasn't a weird mod conflict). :)

@SoftHeartedOutlaw Of course, I'm working on adding a lot of modifiers, as long as it's still balanced, and weapon weight will definitely be one of them.

@Anxiety Hey man, I think it was related to how I programmed the dynamic trait management. It should be fixed now. Let me know if you're still experiencing this issue. Thanks for your feedback

I play with way too many mods, so maybe there's some weird incompatibility, but twice now I've hit a bug when loading a saved game. It's happened on the third or fourth session with a given character. Upon loading the game, I lose the Defenseless trait and immediately hit level 5 Combat Mastering.

I don't have the same problem with the Efficiency Skill mod, which defaults to level 2 if you don't start with the Inefficient trait. The vanilla Strength and Fitness skills also behave normally. Only Combat Mastering is bugged. Maybe something isn't initialized properly when loading a save, so it doesn't get saved properly for the third session?