that's reasonable, the music composers very much need some love and recognition.

i just wanted a more compact showing of music names, but i suppose reducing the text size will do.

One of the reasons I wanted to make this mod is to showcase the names of the musicians for projects, since I feel like the average player misses that information often. As such, I don't think I would hide the artist. Mod source...maybe? I'm very busy, so any change is unlikely unless it's pressing.

any chance to add a config to hide the composer names and mod source?

"Invalid" means the music isn't registered. Most mods will have this, it's not an issue.

I suspected the Hud because- it effects the Hud directly. :shrug:
The Distant Memories has some music tracks that read invalid so guessed maybe it was a conflict with either, if not then I've little clue. ^^;

Distant Memories doesn't use Music Display at all, so it's not that mod.

I'd be confused if Dynamic Hud added a music track and its display listing...contacted the Distant Memories dev to see if he has any insight.

I imagine the problem could be either Final Fantasy - Distant Memories (Alpha) or Dynamic HUD though none of these three mods have updated when this problem had suddenly occurred, which leaves me and 'em scratching our heads.

[14:29:23.878] [Main Thread/WARN] [tML]: Silently Caught Exception:
System.NullReferenceException: Object reference not set to an instance of an object.
at MusicDisplay.DisplayDrawing.DrawMusicDisplay(Single delta, Single& alpha, MusicText text)
at MusicDisplay.DisplaySystem.<ModifyInterfaceLayers>b__8_1()
at Terraria.UI.LegacyGameInterfaceLayer.DrawSelf()
at Terraria.UI.GameInterfaceLayer.Draw()
at DMD<System.Void Terraria.Main:DrawInterface(Microsoft.Xna.Framework.GameTime)>(Main this, GameTime gameTime)
at Hook<System.Void

What errors did you get in the logs? It's unlikely this mod itself did it, and rather another mod using it incorrectly.

Had trouble where this mod was hiding my UI almost entirely (Buffs were visible), don't know how I can troubleshoot to find out why as it wasn't a problem last play session. Exceptions in the log pointed to here and disabling this mod fixed the problem though.

successfully loaded when i turned this mod off

for some reason this mod makes tmodloader think the spooky mod is out of date when used together

Bing chilling

There is already a config option to do that, alongside the scale option.

Could you add an option to change the position of the text? I play with a big monitor and for me it looks it a third/quarter up the screen instead of near the bottom

You the goat for real Gabe, tysm

Added a scale option. Hopefully that helps!

Love this mod!! Just a little bit of a shame you cant change the size of the text and only the opacity

Fixed.

It's a good mod! However, the "Current Music:" part of the localization file is missing.

Whoops! Fixed lol

Hey Gabe, there is currently a bug where "Unknown Track" will always be displayed regardless of the config. I checked the source and the fix is very simple - the dummy "unknown track" does not correctly mark itself as unknown. The default value passed to the constructor is false, and the creation of the unknown track does not substitute it for true.

Relevant GitHub link: https://github.com/GabeHasWon/MusicDisplay/blob/master/MusicDatabase.cs#L40

So I had been thinking about a mod like this one but with support for reading custom song pack files and displaying custom music. Would be amazing with support for that!

Nothing in the mod's vanilla compatibility is hardcoded. Author/game attribution is localized in the same file as all of the names.

would it be possible to implement proper resource-pack-side customization for music pack puporses (specifically ones replacing vanilla music)? with how it's set up right now, you can only really update the titles themselves (since author/game attribution seems to be hardcoded)

It's up to Starlight River to add support. Read the description above.

oke

With UltraSonic I believe you choose the song, so I don't know what the point of seeing the title of the song you're playing is. No either way.

There is any way to make it work with the "UltraSonic" mod?

yes, calamity has added support

If they've added compatibility, sure. I don't make compatibility for other mods.

is this compatible with calamity

Look forward to seeing some of these ideas in the future then :) Thanks for again for a very nice subtle mod that adds just a little bit extra flair to the game. Keep up the good work

This is very low priority, I have a ton going on, but I'll consider it if I remember.

- Color is something I've thought of, though I don't like to push breaking changes and there isn't much demand for it, so I've not done it.
- I could probably make this a config pretty easily. Might do this.
- Font size is also pretty simple (hopefully).
- That would be fixing someone else's mistake; songs only appear if the developers add allow them to, which means Cal Mod's music is being allowed to appear but also not properly localized. This is an issue with Cal Mod, and would be a *ton* of work for me to do for really minor gain (in this context).

Hey, very nice mod, I have some suggestions for it though

- Would love to see color variation between the song name, composer name, and mod name (and being able to set custom colors in the config)
-- Also possibly moving the mod name into a () after the song name i.e: Overworld Day (Terraria). This would compact it a bit better.
- Font size config option.
- ability to blacklist/block certain song names from popping up or the ability to add a custom name for them (This would be a soft fix for scuffed song title names like for me the Vanilla Calamity Music Mod's song name for rain is Mods.UnCalamityModMusic.ModSupport.MusicDisplay.SongNames.Rain

Are you sure the music slot you're passing is valid and modded?

You have a (very funny) mod that replaces all music with that name. Find which mod does that and disable it.

I have an issue where every single displayed song title is Darude - Sandstorm. Any ideas?

ability to change size of text?

That did, in fact, fix it.

I have removed the entry for the 0th music entry, so that error should be fixed. Might still be issues though.

Yes, I am on 1.4.4. I'll test further to see if it's just a mod incompatibility or something with the mod itself.

@coiledAgent: Are you on 1.4.4? I need more info to do anything.

@Spectre22: I don't add in compatibility to other mods, you'd have to ask the devs of that mod.

[05:59:50.894] [.NET ThreadPool Worker/ERROR] [tML]: An error occurred while loading MusicDisplay v1.2.0
The mod(s) have been automatically disabled.
System.ArgumentException: An item with the same key has already been added. Key: 0

(There was more obviously, but it's not possible to copy a whole log file into a Steam comment.)

Those this mod supports the minecraft music mod?

Absolutely not! The only issues this mod has is not having support for a given mod.

any hard incompatibilities

You have the mod installed, enabled and have relevant config turned on on 1.4.3?

doesnt seems to work for me, any idea why?

Done and dusted! Here’s the changelog [discord.com]