holy skill issue

I cant believe people could have to audacity to install literal wallhacks on tboi, smh my head

memphis maybe try reading the description of a mod before ♥♥♥♥♥♥♥♥ in the comments?

@memphis it just puts the outline of a door where doors could be, not where the secret room is, but in places where a room could generate

mod for fatherless cheaters lol

@agentcucco thanks for your advice, it's really helpful! I've done my best to incorporate it into the mod

I will probably delete those if you ping me, to avoid cluttering the chat, but generally the biggest "issues" are the lack of use of enumerations, and overuse of "magic numbers", if you're using static values for anything at all, it's always best to define them as a constant at the top of your file (if the enums.lua doesn't provide them already).

4. You made a custom distance function which is kinda funny, it's not bad perse, but Vector.Distance/DistanceSquared() already exist (i.e. player.Position:Distance(door.Position)). math.sqrt is also a really taxy method, it is adviced you use ^0.5 instead, when working in LUA, don't ask why, the math function is just scuffed, lol.

5. This is truly a personal nitpick and not a real issue, but when checking for variables, it's good to keep this in mind:
'if x then' // 'if x == true or x ~= nil then'
'if not x then' // 'if x == false or x == nil then'
These terms are generally more readable when (and faster to write) when you have more experience coding.

A few nitpicks I found while checking the source:

1. You are barely using enumerations (i.e. typing Isaac.Spawn(1000, ...) instead of Isaac.Spawn(EntityType.ENTITY_EFFECT, ...)), this makes the code pretty unreadable and specially if you start making custom stuff, it might cause issues with dynamic ids and whatnot.

2. On the topic of readability, some of your statements get pretty long, generally it's best to keep each check in its own line.
i.e. 'if x and y then' to
'if x'
'and y'
'then'

3. In this case it doesn't matter, but it's generally a bad practice to define static objects more than once, in your case you're defining a Color every time you spawn an outline, but the color is always the same, so really there's no reason not to define it at the top of your code as a constant.

@agentcucco Haha don't worry about it.

Ok I've now defined the json library, thank you for pointing that out. I'm pretty new to modding, Isaac or otherwise, so your help is much appreciated.

@lunawolf I only just replied an hour ago so don't worry :)

Yeah the mod checks for doors every time you enter a room and places an outline wherever a door can be placed but isn't open. The crawlspace leading to the black market must contain a door entity on the right which the mod detects (although I would've thought that door would be marked as open and thus an outline shouldn't be placed). Regardless, the mod now checks if the room type is a crawlspace and doesn't place any outlines if so, so that shouldn't happen again. Thanks for pointing that out and please let me know if you notice any other bugs.

The error is actually super trivial looking at the source, you just forgot to define the json library, lol.

@sam I can't believe I have fallen victim to one of the classic blunders, lol, sorry about that.

The error appears every time I exit the game (though I presume it procs every time you try to save your mod's data).

Sorry I didn't notice your responses for a bit. Removing door outlines in crawlspaces altogether should have done it, I only got the bug once but that's just because it's the only black market I found with the mod on so far. Basically I just went into a black market crawlspace and it was perfectly normal, so I went into the black market and checked it out but didn't buy anything, and then when I went back out into the crawlspace proper, there was a door outline in the middle of the side of the crawlspace that the black market entrance was. My assumption would be that it just saw that I entered the room through a door and came out in that spot, so that would make it a spot where a door could be, but there wasn't a door there, so therefore it should have an outline. That's only a guess, though.

Door outlines should no longer appear in crawlspaces

I'm not sure how to add screenshots to the mcm options.

Could you tell me more about the error? What were you doing when it appeared? Was it a one-off or a recurring error?

I found a weird bug, when I got a crawlspace that led to a black market and went in and back out of the black market, an outline appeared on the side that the black market entrance is. Nothing gamebreaking or anything but it's been bugging me since

Error in line 62, attempt to index a nil value ('json')

It might be good to add a screenshot with the mcm options

Ok both of these features have been implemented

On Greed Mode there are only 5 possible places for Secret Room:
- Curse Room (left wall)
- Shop (left wall)
- Golden Treasure Room (right wall)
- Silver Treasure Room (right wall)
- Greed Exit (left wall)
If you can change this as well as doors appering in Boss Rooms where is no chance for Secret Rooms to be, that would be nice

Here is a wiki about it:
https://bindingofisaacrebirth.fandom.com/wiki/Rooms#Secret_Rooms

based

tbf I do hate trying to find suitable door locations in 2x2 rooms, might give this a go

Skill Issue