Yeah that example is pretty weird

@Victor I think the point is to avoid using it to hide errors, although a conditional will also not show anything if you put a wrong xpath into it, but whether to use success it as shorthand for conditional is a matter of preference. I'm pretty sure the rimworld wiki example though is wrong though, if it wishes to not use success tag, it can check that all things exist within the first conditional or use second conditional within first one.

XML Extensions also warns about it: https://github.com/15adhami/XmlExtensions/wiki/Debugging-Tools

I see, I read it on the wiki: https://rimworldwiki.com/wiki/Modding_Tutorials/PatchOperations#Extenuating_circumstances_for_.22Success.22

@Victor to be clear <success>Always</success> is equivalent to a conditional on the same xpath, it doesn't hide any other errors or warnings, it only hides the error when xpath wasn't found

@Victor that being said seeing as I wrote this a long time ago, it might have some bad uses of the success tag, I remember doing a lot of defensive checks mainly to make it not break anything when patched mods update, and sometimes it got quite complex, I was very confident that my patches are correct though at the time

@Victor its just a shorthand for a conditional operation, when you have so many operations the conditionals everywhere make it too verbose

I'm taking a look at your patches, I believe you should remove "<success>Always</success>" where you can, as it only serves to hide any possible errors or warnings.

I am changing this to unlisted because I haven't tested anything in 1.6. And I changed all settings to be off by default.

@Victor I haven't encountered that but I kinda want to. It's not really a balanced setting as you also can get genetics expanded animals for free for example. I see why a blacklist might be benefitial though, but on the other disabling this setting makes only intended animals arrive in manhunter packs, so its kinda like a blacklist already. Essentially I would be making my own custom blacklist, which probably warrants a whole new mod

The 'Enable all animals as manhunter' patch has some caveats, for example, some specific animals from Alpha Animals cause weather conditions after dying (example: Darkbeasts), so they are not allowed as manhunter as each dead one ends up adding up a different condition. Would you add a blacklist?

so about this mod, I've added 1.5 tag however I imagine a lot of patches in this are heavily outdated. But due to the way they were made if a patch doesn't work it shouldn't break anything, it just won't do anything

No worries, it seems like an odd git methodology but I get where you're coming from.

@Superfly Johnson well I have a lot of mods and I can't be bothered to keep them all updated on github and I figured having only some of them on git is pointless, plus after updating the mod I would use up my rimworld motivation for the day and none would be left to also upload the update to github, and by the time my motivation replenishes I will have already forgotten about said update. Admittedly not the most productive way of life, but quite conservative on motivation. That being said if there is a particular reason you want it to be on git I can do it

what happened to the git?

there is a small incompatible with the warforge from Forgotten Realms https://psteamcommunity.yuanyoumao.com/sharedfiles/filedetails/?id=2184183669 this mod gives them a food bar. since they don't eat the game is telling me their starvation. I am not getting the mood debuff or the malnutrition debuff so it is good.

@Scorpio it is a setting, it should be in balancing, called something like VAE Accessories. Hmm I was also thinking about a way to not enable new stuff that is on by default for those who already have the mod installed, its a bit annoying to do but I will do that next time. I realize having new stuff suddenly pop upw with each update is also pretty annoying

cam you make that last update a setting? the nerfs part

It's no worries man. I've not touched the game for a while but i'll probably complain some more patches once I come backt o the game in a few years lol

@Superfly Johnson thank you! Feels good to finally have access to steam. Still have to upload the docworld thing tho

Props on the steam release dude. Best patches mod :p