@Protok Sure, added that option now

Thanks for a mod Mlie!
Can you add Friendly Raid to be Asked too. Sometimes they ruin all thing.

@FluffDragon Please see the Reporting Issues section described above

I have been getting a lot of visitors failing to visit after clicking enter, with this stacktrace:

Failed to do traveler incident from (92, 0, 0): Couldn't find anywhere for the traveler to go.
UnityEngine.StackTraceUtility:ExtractStackTrace ()
Verse.Log:Warning (string)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:RimWorld.IncidentWorker_TravelerGroup.TryExecuteWorker_Patch2 (RimWorld.IncidentWorker_TravelerGroup,RimWorld.IncidentParms)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:RimWorld.IncidentWorker.TryExecute_Patch3 (RimWorld.IncidentWorker,RimWorld.IncidentParms)
AskBeforeEnter.Main/<>c__DisplayClass1_0:<AskDialog>b__2 ()

I am on 1.6, using a number of mods that may alter events (rimwar being one), and playing on a crater map with a very small area of valid access, but visitors occasionally still make it into the map.

@Angus Beef The only repeating error I see in that log refers to character editor. Please follow the steps described under Reporting Issues.

Seems to be broken. Does not allow groups to enter when I select enter. Is anyone else having this issue?

https://gist.github.com/HugsLibRecordKeeper/4caca9497739c928102f96cd6b4c6218

Would be cool if there is a mod option that this only comes into effect when you unlocked/claimed a Comms Console.

Then the caravan leaders don't have to yell so loudly for me to get their message.

Looks like it is! Thanks Mlie!

@L. Velociraptor Should be fixed now

Hello Mlie! Looks like there's some kinda issue I'm having with Vanilla Achievements Expanded, here's the debug log, let me know if you'd prefer this some other way or need other info:

Exception filling window for RimWorld.Dialog_Options: System.TypeInitializationException: The type initializer for 'AchievementsExpanded.AchievementHarmony' threw an exception. ---> System.TypeLoadException: Type AskBeforeEnter.RefusalTracker has invalid vtable method slot 16 with method none
[Ref 16AE7692] Duplicate stacktrace, see ref for original
--- End of inner exception stack trace ---
[Ref 8A779049] Duplicate stacktrace, see ref for original
UnityEngine.StackTraceUtility:ExtractStackTrace ()
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Log.Error_Patch2 (string)
Verse.Window:InnerWindowOnGUI (int)
UnityEngine.GUI:CallWindowDelegate (UnityEngine.GUI/WindowFunction,int,int,UnityEngine.GUISkin,int,single,single,UnityEngine.GUIStyle)

@Andreas Updating all my mods, see discord for progress

Any plans to update this for 1.6?

@Gopher There are some pretty simple steps described here on the mod-page on how to find the issue in your setup.
As Ive been using better loading myself with no issues, the problem lies with your mod-setup, not this mod.

Of course not. I am merely following directions and alerting you to the error. I truly do not have time in my life to look into your mod for you and figure out why it's assemblies wouldn't be loading. I just see similar sounding issues in previous comments, so figured the data points i have would be helpful. I am trying to get a load order that works, and dropping yours gave me a pristine load order, is all I can really say.

@Gopher So you only have this mod, vae and better loading active and are experiencing this error?

Well, I dunno what to tell you except that you are wrong, because I have VAE loaded before the mod and there is still this issue? Maybe there is a conflict with BetterLoading, cause it told me all that in a message explaining why it didn't trigger at the start as it normally would for the loading screens.

@Gopher As long as you have VAE loaded before this mod there should be no issues with load order

Betterloading has informed me thus:
The assemblies that failed to load are:
Ask Before Enter - AchievementsExpanded_AskBeforeEnter.dll, AskBeforeEnter.dll, VersionFromManifest.DLL

BetterLoading suggests this means you have a bad load order, or you're missing a dependency, such as HugsLib. I use RimPy's Sort for my mod load order solution, so I am not sure if the position it is in is wrong or if there is a dependency missing, but based on previous comments, I am wondering if there is a compatibility issue with VAE, as I have that mod, as well.

VAE -> ABE order fixes the startup errors.I still get the "Failed to redeem reward TradeCaravanReward" I mentioned. I'm guessing VAE has to add a check if ABE is holding the caravan or just failed.

@StarK I dont get these errors in my tests. Try loading VAE earlier in the list

Hi Mlie. Thank you so much for maintaining all these mods..
I get an error with Vanilla Achievements Expanded aswell.
Turned off nearly all my mods and they are as follows Harmony -> Core -> DLCs -> HugsLib -> ABE -> VAE.
Didn't really mind the startup errors since game launches. But I noticed when summoning a caravan with VAE I would get a "Failed to redeem reward TradeCaravanReward" message on top left but, caravan would arrive but VAE points will be unspent?. I'm not sure who can fix the compatibility so am posting on both pages.
HugsLib Log [gist.github.com]

@GeodesicDragon Does not happen when I test it. You have some other errors in that log as well, you may need to look over your modlist

Getting some errors with Vanilla Achievements Expanded enabled.

ReflectionTypeLoadException getting types in assembly AchievementsExpanded_AskBeforeEnter: System.Reflection.ReflectionTypeLoadException: Exception of type 'System.Reflection.ReflectionTypeLoadException' was thrown.

Could not find type named AskBeforeEnter.RefusalTracker from node <tracker Class="AskBeforeEnter.RefusalTracker"><count>10</count></tracker>
UnityEngine.StackTraceUtility:ExtractStackTrace ()

Exception loading from System.Xml.XmlElement: System.MissingMethodException: Cannot create an abstract class 'AchievementsExpanded.TrackerBase'.
[Ref 28C00382]

Could not find type named AskBeforeEnter.RefusalTracker from node <tracker Class="AskBeforeEnter.RefusalTracker"><count>25</count></tracker>
UnityEngine.StackTraceUtility:ExtractStackTrace ()

Log: https://gist.github.com/HugsLibRecordKeeper/95adf956c36728d3ce303a7704f58c66

ah ok, hehe, i guess sometimes a bit of peace and quiet can be nice lol
(but if you stay alone for ages and start calling a coconut "wilson", be careful)

No I can't walk to anybody either , and no caravans coming which is very nice .Alone and peacefully among the banana and coconut trees

hi @chromium, are you still able to walk to other settlements? if so, maybe they can still reach you too (especially before any vehicles or flying methods are available?)

Promising mod I might try out however I started a new save with a tribe on an island. I don't think anyone will come to me. Maybe I try it in another run.

ok

@物理系魔法师 Then dont enable traders in the mod-options

What I mean is that they should automatically enter when there is no danger on the map, and ask for permission to enter only when there is danger. My current experience is that they ask for permission regardless of whether there is danger or not.

@物理系魔法师 Isnt that the default logic? Just disable caravans in the mod-options

Is there a way to allow caravans to enter directly when there is no danger on the map instead of asking?I couldn't find the relevant option in the settings.

Ahhh yeah it was a group of visitors, I've had this mod for so long I didn't realise the visitors asking was a separate thing haha. Thanks for the reply, sorry to bother you :D

@Kham There is no such option in this mod, perhaps you are referring to the options added regarding visitors in the Hospitality mod?

If you accidentally click "always enter (don't ask again)" is there any way to undo that option? Just clicked it by mistake and really don't want to revert to an earlier save because I just cleared a large raid.

@JSJosh Please see the Reporting Issues section described above

This mod messes with BetterLoading because it says that this mod has an assembly that has failed to load.

Thank you so much been looking for this as I use vehicles and they constantly decide to ram through a forest and not the massive 10 tile wide road I built across my entire base at the center.

Ok my bad, i will test it when i have free time. great mod anyway!!

@baHTheske The first step was to verify it with only this mod loaded, your log contains loads of mods. I cant help you until I can replicate the issue with a minimal mod-list. Please read the steps again.

Uhh should i report the issue on discord or something else

@baHTheske Please see the Reporting Issues section described above

somehow delete this mod and Museums mod fix incident not firing bug for me
dk if its mod conflict

https://gist.github.com/HugsLibRecordKeeper/eb6f7ae660ad62208c27b16c90a89f6d

Okay, thanks.

@Kingdark Yes, its been fixed since 2022

don't mean to nitpick, but has the typo been fixed that's seen in the first screenshot?
It says "a trade caravan is approching" when it should be approaching. Don't mean to nitpick, just want to know, since replacing screenshots isn't a priority.

still needed if you don't like huge caravans entering your map all the time

Is this working with 1.5?