i don't seem to be able to uncap the trading advantage from the 40% cap, even activating the options in mod
it's probably an incopatibility with a mod i guess, never in the history of rimworld i could go the trading bonus go more than 40%
this time i think the culprit might be trading options, trading gen, and unlimited reborn but idk, i have 500 mods so who knows

@Orakuoria There is no Japanese translation in it

Is this supported for Japanese translation?

@azrobbins Remove `tradeable.GetPriceTooltip(TradeAction.PlayerBuys)` in `MainTabWindow_TradeStock.CacheTradeables(ITrader trader)`. It's a bug in Harmony library.

@brucethemoose Cannot replicate that issue. Perhaps a mod-conflict?

@Kateye Fixed in the latest update

I'm having an issue:
The setting "Invert bargain colors" isn't being saved. Other settings appear to be saved correctly, but if you set "Invert bargain colors" (you can go to a trader to verify the invert worked), save the game, then quit and restart, you'll find "Invert bargain colors" is disabled.

I just have to say, thank you to both Sladkis and Mlie. This actually makes trading worthwhile, especially with SRTS. Buy low, sell high can actually be a thing. I love it.

Getting this error when hovering over the price in the trading menu:

https://paste.ee/p/CE32x

(Sorry I dont have the full hugslib log, it overflowed from some other GUI error, but ask and I shall provide it).

Just wanted to note that this mod is incompatible with the "What's for sale?" Mod. (https://psteamcommunity.yuanyoumao.com/sharedfiles/filedetails/?id=2396808851)

It works initially, but when you load the game from a save after you have looked at what other towns have for sale, the screen from the What's for sale mod will be empty.

Probably not worth fixing, but I thought I would let you know.

:00000
Thankssss

@Hades the King @Hyomoto @BladeofSharpness
There is now a setting for inverting the colors on the trade-screen

I think itd make more sense that way

Yeah i can see why its confusing when looking at the colors and the more i look at this i realize its really weird that its inverted(?) Can we have an option to invert the price and the color if thats possible

I don't want a very high price improvement stat on my pawn to lower the sale price of their own goods.

Is there a way to increase the maximum 40% bonus to trade improvement stat?

Indeed, thanks.

@BladeOfSharpness It might be covered to some extent by https://psteamcommunity.yuanyoumao.com/sharedfiles/filedetails/?id=2022959333

Hi Mlie. I know you seldom add additional features to a mod, but a very minor one. The mod already propose several options to tweak prices, etc. And I have so far not found any trade mod which would simply multiply the silver amount of traders by a given amount. Just that, a coefficient. I don't want these fancy mods altering just too many features at once on traders, but a multiplier to silver availability would be super great!

The issue isn't the colors, green good/red bad is obvious. Take a peek at the screenshot: the trader needs this. The price is _BAD_ for buying and _GOOD_ for selling. Yet the green is next to the buy arrow, and red next to the sell arrow, implying that it's GOOD to buy and BAD to sell. Yes, it correlates to the price, but that isn't how the screen is set up visually. Blade is right, if that's the case the price should just be colored.

Otherwise, I think this would make it more readable at a glance, making it obvious which direction is advantageous instead of which price. Some people are used to it, but the option to swap would be welcome. As I said, I've consistently had this issue and finally pinned down why. To my eye, the bars actually make the information harder to understand because they are visually attributable to the arrows, not the price.

https://imgur.com/a/3fl2V1y

I too find the color coding confusing. Why just not put higher prices in red and lower prices in green, that would be less misleading.

@Hyomoto The colors are not connected to the arrows, they are connected to the price. Red -> bad, green -> good

I have had a lot of issues reading the information that this mod gives, but I only now realized why that is. The colors are reversed. Let me explain,

When the trader doesn't need something, and so the buy price is favorable, the color green is on the right side. But the arrow to *buy* goods is on the left side. So basically the buy arrow is pointing to the red, and the sell arrow to the green: precisely the opposite of what the information is trying to convey.

Some people are probably used to this, but is there any chance of getting a setting that will swap the side that the colors are drawn to?

@BladeofSharpness

I was using it last night with the tooltips.
Any other trade mods you use?

Still working nicely, it gives a bit of 'strategy' to trading.
Oddly, since a few days the tooltip about 'trader wants this / trader does not' is missing.

When did you sneak this one through?! I thought I was screwed until the VE trade mod.

THANKS!!!

this good mod

Nice! Adds immersion and give traders personality and possible storytelling.

0.0