Butiksside
The Binding of Isaac: Rebirth
Alt Diskussioner Skærmbilleder Illustrationer Broadcasts Videoer Værksted Nyheder Guider Anmeldelser

The Binding of Isaac: Rebirth

Butiksside
The Binding of Isaac: Rebirth >  Værksted > Wofsauges værksted > [AB+|Rep(+)] External Item Descriptions > Diskussioner
[AB+|Rep(+)] External Item Descriptions
Beskrivelse Diskussioner364 Kommentarer7160 Ændringsbemærkninger
Denne tråd er blevet låst
reddedpixel 4. feb. 2023 kl. 15:44
AB+ | Game crashes after lots of errors in console
Hey, my game crashes every other time I enter the boss room. I'm pretty sure it's from this mode, because when I check the console, there are loads of error messages about this mod saying "attempt to index a boolean value (local 'player')". I am playing on AB+.
Also, transformations in the descriptions of items make the same error appear in console.

Edit: link to screenshot with the error (triggered by spawning a "One makes you larger" pill)
https://psteamcommunity.yuanyoumao.com/sharedfiles/filedetails/?id=2926125927
Sidst redigeret af reddedpixel; 4. feb. 2023 kl. 15:55
< >
Viser 1-6 af 6 kommentarer
Buurazu 4. feb. 2023 kl. 17:09 
Very interesting error; I believe it's because another of your mods is setting the "REPENTANCE" constant to false, despite that being a really really bad idea. (The only valid values for it are nil, or true, and it being set to false could mess up our checks for Repentance characters.)

I've updated the mod on github to more thoroughly check the constant's value, as well as setting it back to nil or true if it detects it's set to false, please check if this fixes your issue: https://github.com/wofsauge/External-Item-Descriptions/archive/refs/heads/master.zip

Thank you for providing the debug console error, it made it easy to trace back the issue compared to most bug reports.
#1
Wofsauge  [udvikler] 5. feb. 2023 kl. 15:26 
Hello, we pushed a new update now. Can you test if it now works better and no errors occur anymore?
#2
reddedpixel 6. feb. 2023 kl. 11:49 
Hi, thank you for looking into this! As a Comp Science student, this is a very interesting bug. I'll check in a few hours and let you know.
#3
reddedpixel 6. feb. 2023 kl. 13:18 
Yep, no error now! Thank you so much!
#4
Buurazu 7. feb. 2023 kl. 0:32 
Oprindeligt skrevet af reddedpixel:
Hi, thank you for looking into this! As a Comp Science student, this is a very interesting bug. I'll check in a few hours and let you know.
Ah, then I'll go into more detail. It was because I used the fact that "nil" is the terminator for tables in Lua to write a super short line that's AB+ compatible:
EID.players = { EID.player, REPENTANCE and EID.player:GetOtherTwin() }
This works fine if REPENTANCE is true, or REPENTANCE is nil, but if it's false, it will put "false" in the table.
#5
reddedpixel 7. feb. 2023 kl. 15:55 
Oprindeligt skrevet af Buurazu:
Oprindeligt skrevet af reddedpixel:
Hi, thank you for looking into this! As a Comp Science student, this is a very interesting bug. I'll check in a few hours and let you know.
Ah, then I'll go into more detail. It was because I used the fact that "nil" is the terminator for tables in Lua to write a super short line that's AB+ compatible:
EID.players = { EID.player, REPENTANCE and EID.player:GetOtherTwin() }
This works fine if REPENTANCE is true, or REPENTANCE is nil, but if it's false, it will put "false" in the table.

Ah, that's quite funny. And definitely a cool solution on your part! Thanks for helping and sharing!
#6
< >
Viser 1-6 af 6 kommentarer
Per side: 1530 50