Butikssida
RimWorld
Alla Diskussioner Skärmbilder Konst Sändningar Filmer Workshop Nyheter Guider Recensioner

RimWorld

Butikssida
RimWorld >  Workshop > Symbolics workshop > HugsLib > Diskussioner
HugsLib
Beskrivning Diskussioner41 Kommentarer2204 Ändringar
Orion 27 mar, 2020 @ 11:17
Please log assembly file version of loaded mods
Hey there,

I'm not sure if it was always like this, but I noticed that in HugsLib logs I can only see the assembly version of mods. This version usually doesn't change (or shouldn't, since it breaks mods relying on the assembly), it's kind of useless for debugging.

I often get reports from players where I suspect they're running an old version of some mod, but I can't tell from their logs. Could you please log the assembly file version (as you do with HugsLib itself)?

This would be of great help. Thanks in advance.
< >
Visar 1-10 av 10 kommentarer
Symbolic  [utvecklare] 27 mar, 2020 @ 12:57 
Hey!
Currently the assembly file version is logged whenever it is greater than the assembly version- for all assemblies, not only HugsLib. Have you noticed any instances where that is not the case?
#1
Orion 27 mar, 2020 @ 13:36 
Yeah... I my list it doesn't show for any mods, except HugsLib. I can link you a log tomorrow...
#2
Orion 28 mar, 2020 @ 3:43 
Here it is: https://gist.github.com/7a2baba8aa10ae89c0ebbb9c7fb8baa8
#3
Symbolic  [utvecklare] 28 mar, 2020 @ 5:34 
I assume some of these other assemblies have an AFV greater than their AV?
Sure, I'll investigate.
#4
Orion 28 mar, 2020 @ 5:47 
I'm only using 3 digits... So like 1.1.4 ... Could that be the problem?
#5
Orion 28 mar, 2020 @ 5:48 
Isn't the comparison to the AV a bit specific? Maybe it'd be better to check if it's different then the default value...
#6
Symbolic  [utvecklare] 28 mar, 2020 @ 9:41 
That might be the problem- perhaps System.Version assumes there is a leading zero digit.
The original idea with "greater than" was to filter out cases where the author just doesn't bother incrementing AFV along with AV. However, I probably will switch that to "not equal" for more clarity.

I looked at some other logs, and the current system seems to be working for some mods:
TD Enhancement Pack(Uuugggg.TDPack): 0Harmony(2.0.0.8), TD_Enhancement_Pack(av:1.0.0.0,fv:1.3.8.0) 4M Mehni's Misc Modifications(Mehni.4M): 4M(av:0.1.1.7,fv:0.1.1.8)
#7
Orion 28 mar, 2020 @ 11:08 
I guess you could do that for av too, then. I'm leaving it default for my mods since I realized that when I change it, mods break that are built against my assemblies.
#8
Symbolic  [utvecklare] 29 mar, 2020 @ 6:40 
Just released an update with the changes.
Also, I sure am glad you reported this.
Turns out, the LoadFolders configuration was being ignored while looking up the AFV. As a result, AV was reported correctly, while the AFV was read from the same assembly for 1.0.
#9
Orion 29 mar, 2020 @ 8:41 
Ah, cool. That might have been part of the issue as well.
#10
< >
Visar 1-10 av 10 kommentarer
Per sida: 1530 50