RimWorld

RimWorld

HugsLib
Vectorial1024 3. mar. 2020 kl. 3:44
UpdateFeatureDef is unexpectedly "duplicated"
UpdateFeatureDef does not seem to be differentiated between different HugsLib mods.

Try:

1. Make two mods with distinct package ID that define UpdateFeatureDef with the same name
2. Load the game
3. Error: duplicated UpdateFeatureDef

This never happened before. I suspect it may have something to do with the latest fix to the ModIdentifier issue.

Current workaround is to change the UpdateFeatureDef from different mods to hav different names.
< >
Viser 1-8 af 8 kommentarer
Symbolic  [udvikler] 3. mar. 2020 kl. 5:41 
By name, do you mean def name, or modNameReadable?
Because if it's the latter, then it's a side effect of changing to the new news system which does not require an assembly with a matching ModBase.ModIdentifier in it.
The modIdentifier from the news defs is now only used to identify the "group" they belong to- as in, which version among them is the highest already seen, an whether the "group" is ignored by the player.
In theory, any mod can now display its news under any modIdentifier, including multiple ones.

If that is a problem (as in- not a theoretical one) I can see about putting some logging and safeguards in place.
Vectorial1024 4. mar. 2020 kl. 3:19 
To clarify, the news defs have the same def name, but belong to different mods

Hmmm, I may need to go back to my mods to have a look again to be sure; I guess I may have deleted the modIdentifier tag after I read that the modIdentifier tag is not used to uniquely identify mods anymore

I may have misunderstood something
Sidst redigeret af Vectorial1024; 4. mar. 2020 kl. 3:20
Proxyer 8. mar. 2020 kl. 1:56 
It has nothing to do with threads, but let me ask a question.

In 1.0
I was able to put a translation of UpdateFeatures.xml in Languages\***\ DefInjected\HugsLib.UpdateFeatureDef\UpdateFeatures.xml, isn't it translatable in 1.1?

Currently, it is placed in the News folder instead of Def, so it is not recognized as Defs, so translation can not be applied.

Thank you.
Symbolic  [udvikler] 8. mar. 2020 kl. 10:49 
@Proxyer
Yes, this is a bit of a regression issue. Currently, there is no translation support for news defs- but adding it should be possible. I'll see if I can look into this eventually.

Proxyer 8. mar. 2020 kl. 11:10 
@UnlimitedHugs
Thank you very much. The urgency is low, so please wait until other important matters are cleared. :lunar2019piginablanket:
Vectorial1024 12. mar. 2020 kl. 7:12 
Oprindeligt skrevet af UnlimitedHugs:
By name, do you mean def name, or modNameReadable?
Because if it's the latter, then it's a side effect of changing to the new news system which does not require an assembly with a matching ModBase.ModIdentifier in it.
The modIdentifier from the news defs is now only used to identify the "group" they belong to- as in, which version among them is the highest already seen, an whether the "group" is ignored by the player.
In theory, any mod can now display its news under any modIdentifier, including multiple ones.

If that is a problem (as in- not a theoretical one) I can see about putting some logging and safeguards in place.

I checked again, and indeed, if I keep the modIdentifier field as is, the news can be loaded just fine.

Thanks for the clarification anyways!
Symbolic  [udvikler] 24. mar. 2020 kl. 4:39 
@Proxyer
Re-enabled translation support for update news defs in the latest update.
The translation syntax has not changed, they still count as regular defs for translation purposes.
Proxyer 24. mar. 2020 kl. 15:46 
@UnlimitedHugs
Thank you for your works!
I will begin the process of restoring the translation.
< >
Viser 1-8 af 8 kommentarer
Per side: 1530 50