The Fishing Combination uses restoration potion instead of the regeneration potion in its Recipe

Will be fixed

[射手药剂包]会强制覆盖/清除[箭术药水]，[暴怒药水]，[怒气药水]和[弹药储备药水]并应用这四种药水的能力，但实际上[箭术药水]只是被清除而没有正确生效。造成一种情况：分开喝四瓶药后，再喝下一瓶射手药剂包，弓的面板反而会降低。测试时仅应用了lite和dragonlens。以下为机翻内容

The Archer Potion Pack forces overlays/clears the Arrow Potion, Rage Potion, Anger Potion, and Ammo Reserve Potion and applies the abilities of these four potions, but in reality the Arrow Potion is only cleared and does not take effect properly. Create a situation: after drinking four bottles of medicine separately, and then drinking a Archer potion pack, the bow panel will be lowered instead. Only lite and dragonlens were used in the tests

Isn't this intended?
Archer/Ranger combination overrides all components of it and makes player immune to their respective buffs, so you can't stack both Ranged Combination and Archery potion effects.

如果我们有两把面板一样的武器，一把是弓，一把是枪。由于药剂包中有箭术药水，喝下药剂包后弓的面板应该比枪高。
但事实上，两把武器的面板是一样的。药剂包中箭术药水没有正确生效
If we have two weapons with the same panel, one is a bow and the other is a gun. Since the potion pack contains Archery potions, the bow panel after drinking the potion pack should be higher than the gun.
But in fact, the panels on both weapons are the same. Archery potion does not work correctly in the potion pack

I can prove it with Molten Fury and Chain Gun

recent update seems to have caused this mod to produce errors;

[23:17:34.435] [.NET TP Worker/WARN] [tML]: Silently Caught Exception:
System.ArgumentException: Unable to sort because the IComparer.Compare() method returns inconsistent results. Either a value does not compare equal to itself, or one value repeatedly compared to another value yields different results. IComparer: 'System.Comparison`1[System.Int32]'.
at System.Collections.Generic.ArraySortHelper`1.Sort(Span`1 keys, Comparison`1 comparer)
at System.Collections.Generic.List`1.Sort(Comparison`1 comparison)
at Terraria.UI.ItemSorting.ItemSortingLayers.<>c.<.cctor>b__39_34(ItemSortingLayer layer, Item[] inv, List`1 itemsToSort) in tModLoader\Terraria\UI\ItemSorting.cs:line 694
at Terraria.UI.ItemSorting.SetupWhiteLists() in tModLoader\Terraria\UI\ItemSorting.cs:line 828
at Terraria.ModLoader.ModContent.Load(CancellationToken token) in tModLoader\Terraria\ModLoader\ModContent.cs:line 375
at Terraria.ModLoader.ModLoader.Load(CancellationToken token) in tModLoader\Terraria\ModLoader\ModLoader.cs:line 134
at Terraria.ModLoader.ModLoader.<>c__DisplayClass48_0.<BeginLoad>b__0() in tModLoader\Terraria\ModLoader\ModLoader.cs:line 112
at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
at System.Threading.ThreadPoolWorkQueue.Dispatch()
at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()

Mods list? Doesn't seem to be happening for me.

"TerrariaAmbienceAPI",
"BossChecklist",
"AtmosphericLava",
"AmmoTool",
"CalamityFlamethrowers",
"StarsAbove",
"SortingFolders",
"StructureHelper",
"CatalystMod",
"BTitles",
"BetterBlending",
"CalValEX",
"LookMod",
"SerousCommonLib",
"ColoredDamageTypes",
"ParticleLibrary",
"AutoHealMod",
"EnchantedGlint",
"BossHealthBar",
"HighFPSSupport",
"CameraMods",
"RecipeBrowser",
"RainOverhaul",
"ImprovedTorches",
"DialogueTweak",
"SkippysWaves",
"WingSlotExtra",
"LootBeams",
"BetterZoom",
"HPAware",
"Lights",
"miningcracks_take_on_luiafk",
"CalamityAmmo",
"SylaResourcePackLib",
"SummonsUI",
"CalamityHunt",
"Luminance",
"ClamityMusic",
"Clamity",
"WombatQOL",
"Remnants",
"InventoryDrag",
"MagicStorage",
"SubworldLibrary",
"InnoVault",
"CalamityMod",
"CalamityModMusic",
"CalamityOverhaul",
"ImproveGame",
"TerrariaAmbience",
"PetsOverhaul",
"RealisticSky",
"PrettyRarities"

I am noticing now it is an incompatibility with one of them as it works fine by itself, I feel daft not realising

I have fixed my problem, one of my mods didn't update itself and was pointing the blame to the wrong place

NPCs that have two or more sale inventories to choose between can't show their happiness dialogue

3rd lvl alchemist's charm russian translation mistake in description "...над Высшой ведьмой..." instead of "...над Высшей ведьмой...". I play with Calamity and Project tRU

an issue i have experienced is that the config doesnt actually change the npcs, like price scaling and and item prices

I have an issue with the mod when I have Magic storage enabled which causes and error here is a copy of the logs to show you.

Here is the logs

[08:17:21.497] [.NET TP Worker/WARN] [tML]: Silently Caught Exception:
System.IndexOutOfRangeException: Index was outside the bounds of the array.
at System.Collections.Generic.ArraySortHelper`1.PickPivotAndPartition(Span`1 keys, Comparison`1 comparer)
at System.Collections.Generic.ArraySortHelper`1.IntroSort(Span`1 keys, Int32 depthLimit, Comparison`1 comparer)
at System.Collections.Generic.ArraySortHelper`1.IntroSort(Span`1 keys, Int32 depthLimit, Comparison`1 comparer)
at System.Collections.Generic.ArraySortHelper`1.IntroSort(Span`1 keys, Int32 depthLimit, Comparison`1 comparer)
at System.Collections.Generic.ArraySortHelper`1.IntroSort(Span`1 keys, Int32 depthLimit, Comparison`1 comparer)
at System.Collections.Generic.ArraySortHelper`1.Sort(Span`1 keys, Comparison`1 comparer)
at System.Collections.Generic.List`1.Sort(Comparison`1 comparison)
at Terraria.UI.ItemSorting.ItemSortingLayers.<>c.<.cctor>b__39_34(ItemSortingLayer layer, Item[] inv, List`1 itemsToSort) in tModLoader\Terraria\UI\ItemSorting.cs:line 694
at Terraria.UI.ItemSorting.SetupWhiteLists() in tModLoader\Terraria\UI\ItemSorting.cs:line 828
at Terraria.ModLoader.ModContent.Load(CancellationToken token) in tModLoader\Terraria\ModLoader\ModContent.cs:line 378
at Terraria.ModLoader.ModLoader.Load(CancellationToken token) in tModLoader\Terraria\ModLoader\ModLoader.cs:line 134
at Terraria.ModLoader.ModLoader.<>c__DisplayClass48_0.<BeginLoad>b__0() in tModLoader\Terraria\ModLoader\ModLoader.cs:line 112
at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
at System.Threading.ThreadPoolWorkQueue.Dispatch()
at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()

[08:17:21.497] [.NET TP Worker/WARN] [tML]: Silently Caught Exception:
System.ArgumentException: Unable to sort because the IComparer.Compare() method returns inconsistent results. Either a value does not compare equal to itself, or one value repeatedly compared to another value yields different results. IComparer: 'System.Comparison`1[System.Int32]'.
at System.Collections.Generic.ArraySortHelper`1.Sort(Span`1 keys, Comparison`1 comparer)
at System.Collections.Generic.List`1.Sort(Comparison`1 comparison)
at Terraria.UI.ItemSorting.ItemSortingLayers.<>c.<.cctor>b__39_34(ItemSortingLayer layer, Item[] inv, List`1 itemsToSort) in tModLoader\Terraria\UI\ItemSorting.cs:line 694
at Terraria.UI.ItemSorting.SetupWhiteLists() in tModLoader\Terraria\UI\ItemSorting.cs:line 828
at Terraria.ModLoader.ModContent.Load(CancellationToken token) in tModLoader\Terraria\ModLoader\ModContent.cs:line 378
at Terraria.ModLoader.ModLoader.Load(CancellationToken token) in tModLoader\Terraria\ModLoader\ModLoader.cs:line 134
at Terraria.ModLoader.ModLoader.<>c__DisplayClass48_0.<BeginLoad>b__0() in tModLoader\Terraria\ModLoader\ModLoader.cs:line 112
at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
at System.Threading.ThreadPoolWorkQueue.Dispatch()
at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()

[08:17:21.498] [.NET TP Worker/ERROR] [tML]: An error occurred while loading
The mod responsible is unknown and tModLoader must be restarted.
System.ArgumentException: Unable to sort because the IComparer.Compare() method returns inconsistent results. Either a value does not compare equal to itself, or one value repeatedly compared to another value yields different results. IComparer: 'System.Comparison`1[System.Int32]'.
at System.Collections.Generic.ArraySortHelper`1.Sort(Span`1 keys, Comparison`1 comparer)
at System.Collections.Generic.List`1.Sort(Comparison`1 comparison)
at Terraria.UI.ItemSorting.ItemSortingLayers.<>c.<.cctor>b__39_34(ItemSortingLayer layer, Item[] inv, List`1 itemsToSort) in tModLoader\Terraria\UI\ItemSorting.cs:line 694
at Terraria.UI.ItemSorting.SetupWhiteLists() in tModLoader\Terraria\UI\ItemSorting.cs:line 828
at Terraria.ModLoader.ModContent.Load(CancellationToken token) in tModLoader\Terraria\ModLoader\ModContent.cs:line 378
at Terraria.ModLoader.ModLoader.Load(CancellationToken token) in tModLoader\Terraria\ModLoader\ModLoader.cs:line 134
[08:17:33.199] [Main Thread/DEBUG] [tML]: Process.Start (UseShellExecute = True): "tModLoader-Logs"