Butiksside
Master of Orion
Alt Diskussioner Skærmbilleder Illustrationer Broadcasts Videoer Værksted Nyheder Guider Anmeldelser

Master of Orion

Butiksside
Master of Orion >  Værksted > WhatIsSols værksted > Unofficial Code Patch Steam Workshop > Diskussioner
Unofficial Code Patch Steam Workshop
Beskrivelse Diskussioner79 Kommentarer914 Ændringsbemærkninger
Albinator 11. jan. 2021 kl. 1:19
Bug report: Travel time between 2 systems with leader
Hello,
The travel speed bonus of leaders seems not to be used for the ETA calculation, while travelling between systems.
When I want to go to the system next to my fleet (not the one it is on), the ETA is 2 turns.
When I go to the system, the fleet instantly reaches the destination (as if the ETA was 1 turn).
I did some test, and here are my deductions:
I have 2 travel-speed bonus leaders in the fleet (10% and 15%). If I send the 10% ship alone, it takes 2 turns. If I send the ship with +15% alone (or with the whole fleet, doesn't matter), it takes 1 turn but displays a 2 turns ETA.
Here is a save-file link:
https://drive.google.com/drive/folders/1ejTg5eOLSiCcniLnJLvBi4HukdlyXxz8?usp=sharing
To reproduce, use the fleet at the bottom on my empire, in Wolf system, and go to the silicoid one (Tahon). Beware, there are 2 fleets on the node, one battleship with no move left, and the whole fleet is behind ;)
This is the same save-file than for the building-list issue.
< >
Viser 1-6 af 6 kommentarer
WhatIsSol  [udvikler] 11. jan. 2021 kl. 8:53 
Only the highest leader's value is used. Very possible this is just a rounding issue.
#1
Albinator 11. jan. 2021 kl. 9:20 
Yeah, I knew only the highest leader bonus was used, that's why I tried to split the fleet with/without each leader, and see the problem is still present when only the highest leader is in the fleet...
Since 10% travel speed bonus takes 2 turns to travel, and 15% travel speed bonus takes 1 turn, we're indeed at the very edge of the 1 or 2 turns limit ^^
#2
WhatIsSol  [udvikler] 11. jan. 2021 kl. 9:23 
Looks like the Leader bonus is just not in the calculation at all. I added the racial trait awhile ago to it.

This only effects the ETA on the screen, not as you indicated the actual travel time.

It is also just another one of those - why calculating it in one place when you can write the same code in two places, but different.
Sidst redigeret af WhatIsSol; 11. jan. 2021 kl. 9:24
#3
Albinator 11. jan. 2021 kl. 9:24 
Yeah, I don't know which one is wrong. The screen says 2 turns, and what happens is only 1 turn.
#4
WhatIsSol  [udvikler] 11. jan. 2021 kl. 9:44 
The Travel time is correct the onscreen ETA is not
#5
WhatIsSol  [udvikler] 11. jan. 2021 kl. 10:16 
Bug.0.0.6.2a: Fleet ETA displayed in the UI is not taking into account any assigned leader travel bonus, this is a display issue only
Fix.0.0.6.2a: Added missing logic to travel bonus if any in the calculation
#6
< >
Viser 1-6 af 6 kommentarer
Per side: 1530 50