multiple songs are incorrectly labeled as being from terraria otherworld

is it calamity to

Could you make it so the display wis show the music box turned on if you have it recorded?

Makes sense. I'll see to it, when I am able to.

would it be possible to make a toggle in config so that the player only appears when the inventory is open?

can you make it so it only requires hearing the theme, instead of recording the box?

Ive reported that same issue back in Oct of 2023, not sure when it broke, but the Vanilla Calamity Music did work properly prior to tModLoader updating to support Terraria 1.4 patch

The vanilla calamity music mod doesn't seem to properly assign its music boxes (i.e. every track is 'no music box assigned' in the player and the music boxes also don't show up in the player), is this something you need to handle, or on the end of VCMM?

Oh that's cool, yeah I would've never found that out since i'm playing w/ alchemist npc and just buy all the music boxes from the musician guy

Its the Record Music feature. If you put empty music boxes in the music player, you are able to press the button to record music as if you had it in your accessory slot.

What is the little circle button between next song and enable listening? smart cursor doesn't have a tooltip for it and it's not clickable, is this a stupid question and i'll figure out what it is later once it unlocks or is it just an un-implemented feature right now or?

Any way you could add an option to make the music player hide/show itself when you close/open your inventory, so it doesn't have to be open all the time?

+1 for option to disable certain songs. Thanks for the mod!

can you add option to disable selected music and prevent it from playing?

I will take a look when I can, thanks for the report

Sorry for the late report of an issue/oddity. Would like to report that the music tracks from Vanilla Calamity Mod Music (https://psteamcommunity.yuanyoumao.com/sharedfiles/filedetails/?id=2816188633) are showing up as "No assigned music box" with the default music box sprite in tMusicPlayer. Also discovered then when filtering music tracks by mod, the mod does not even appear, while other music mods do. All music from the mod do have music boxes (with unique sprites) and are still record when a music box is equipped in game.

Prior to tModLoader's update to support 1.4, these tracks did properly show up in tMusicPlayer.

Honestly, anything that shows the currently playing track isn't already recorded would be nice. Simply having the record button turning red (when track isn't already collected) for example. But yeah, the blue/green background would also work so long as it switches once recorded :)

Oh I see, yeah the MusicPlayer does not follow any collected logic. Its so you can actually see the music box, but I could change the background to blue.

Yeah, that's about what I recall but what im seeing is this; https://i.imgur.com/ceOY3hM.png

"Desert" isn't collected but still displays as such... So the only way of knowing if a track is recorded is to open up the playlist and search for the track to see if you already have it or not.

Edit: Just for completions sake; After recording "Desert" https://i.imgur.com/24xr6Hr.png

Music Boxes are transparent on a blue background if not collected. When collected, they are opaque and on a green background. If you are also talking about the unrecorded music box, that one is always transparent and filling up the stored music boxes to the max does not change that.

Maybe I'm going blind but wasn't the musicbox ~50% transparent if it wasn't recorded before? I don't see any checks or anything. Instead, I have to open up the UI, search for the track to see if it is there or not. Is this the intended behaviour now or some sort of bug? If the former, could an option to just disable record button if the musicbox exists inside the jukebox(?)

Oh, well that explains the poor looping choices we have at resourcepacks, will wait for a music update

Terraria music logic unfortunately doesn't work like that. If a playlist/see feature were implemented, the entire music code base would need to be overhauled, so this is not a planned feature.

we need a seek feature so we can jump to specific times in the track

alright, was it a byproduct from porting the mod?

@IfedtheSpatters
The keybind is now a ModCommand. Use '/musicplayer' in chat to toggle visibility.

what happned to the option to bind hiding the music player to a key?

Hopefully this doesnt bite me in the future but I went ahead and forced an update for stable that has parity with the 1.4.4 version. Enjoy

OMG, where was this mod all my life?!

Due to complications, I wont be able to update the v1.4.3 of tModLoader's tMusicPlayer with all the new systems and features of the ported version. I will try to get any bug fixes taken care of though.

@Shoes4Clues, okay yeah I had ran into and resolved those issues for the upcoming version. Just give me some time

so it turns out most of the bugs are only on list mode, when in tiny mode it's fine

alright

I have been in the process of porting this mod to 1.4.4. When I finish and release I will attempt to squash these bugs for the 1.4.3 version.

when i try to scroll through music it always defaults to "eerie", even when i don't have the music box for it

also, scrolling down too far breaks all guis

ran into both ellestuff and BlackGhost's issues

can i add my own music in this??

i dont know if i completly misuse the mod or not but i cant seem to be able to play any music with it, when i press the play button in detailed tab the screen flickers and does nothing(i do have the specific music box for the song im trying to play), the "<" ">" buttons dont work on the small ui,idk if its my mods doing it or something else, ill try to disable some

@Sandbox Enjoyer
Late reply but that does sound like a minor issue. Recorded music boxes should be immediately playable after being recorded. I'll have an update out soon to fix this issue.

Nevermind, you have to record the music boxes, then take the music box out and put it back in again. You also have to disable the button that disables the mod's functionality.

I'm not sure what does this, but usually the "Play" button doesn't come out of the grey position, and I sometimes can't play songs from the player.

can i add my own music in this?

Oh also you can look at the github (https://github.com/SheepishShepherd/tMusicPlayer) to see changes i make over time.

I may get around to updating change logs for all my mods eventually. I'll also see if I can automate it if possible.

Sorry, just updated the change notes. The new update just fixed an error that would sometimes happen when reloading mods.

hey, is there a changelog anywhere for v0.10?

Hi, I'm playing with fargo's souls and it seems to mess up the music boxes in the music player. the Deviantt's music plays Overworld Day, which plays Eerie, and so on. I also can't cycle between songs

Could you open a discussion thread and post your full log as a link/attachment?

Hello when I tried to install this mod I got this error

"System.NullReferenceException: Object reference not set to an instance of an object.
at tMusicPlayer.MusicUISystem.PostAddRecipes() in tMusicPlayer\MusicUISystem.cs:line 45
at Terraria.ModLoader.SystemLoader.PostAddRecipes(Mod mod) in tModLoader\Terraria\ModLoader\SystemLoader.cs:line 100
at DMD<Terraria.ModLoader.RecipeLoader::PostAddRecipes>()
at Terraria.Recipe.SetupRecipes() in tModLoader\Terraria\Recipe.cs:line 13413
at Terraria.ModLoader.ModContent.SetupRecipes(CancellationToken token) in tModLoader\Terraria\ModLoader\ModContent.cs:line 429
at Terraria.ModLoader.ModContent.Load(CancellationToken token) in tModLoader\Terraria\ModLoader\ModContent.cs:line 360
at Terraria.ModLoader.ModLoader.Load(CancellationToken token) in tModLoader\Terraria\ModLoader\ModLoader.cs:line 12"

Not too great at understanding logs so I've got no clue what's causing this besides a recipe or something

It has been replaced with the Journey Mode research feature. Music Boxes must be obtained legitimately or use Cheat Sheet to obtain all music.