Butiksside
Project Zomboid
Alt Diskussioner Skærmbilleder Illustrationer Broadcasts Videoer Værksted Nyheder Guider Anmeldelser

Project Zomboid

Butiksside
Project Zomboid >  Værksted > Neidmares værksted
198 vurderinger
Spear Crafting Fix
Beskrivelse Diskussioner0 Kommentarer27 Ændringsbemærkninger
2
   
Pris
Føj til foretrukne
Gjort til foretrukken
Fjern som foretrukken
Build 41, Balance, Items, Weapons
Filstørrelse:
Offentliggjort:
63.675 KB
19. jan. 2023 kl. 1:24
1 ændringsbemærkning ( vis )
Designet af:
Neidmare
Offline
Se alle 8718 samlinger (nogle kan være skjulte)
16,580 Unikke besøgende
39,838 Nuværende abonnenter
881 Nuværende foretrukne

Abonner for at downloade
Spear Crafting Fix

Beskrivelse
What does this do?

This patch fixes the durability of spears with attachments.
In the base game, when you attach a weapon to a spear, the resulting spear can not reach 100% durability without repairs.

For example: Take a hunting knife with 100% durability and a crafted spear with 100% durability and attach the knife.
The resulting `Spear with hunting knife` has ~60% durability.

This mod makes it so the spear has the proper 100% durability.



This happens because of a bug or oversight in the game code.
The maximum durability is always the minimum of weapon and spear - but in absolutes.
Crafted spears have a max durability of 5, whereas the attached variants have more.
Therefore the spears can never reach full durability after a craft. This mod fixes this.

The fix calculates the durability in percentages and takes the minimum of the percentage, then
multiplies it by the max durability.

I updated the uncrafting logic as well to ensure that you can not get additional durability by crafting + uncrafting repeatedly.


Compatibility
The mod is safe to add or remove at any time.
It should work with all other mods that add spears with attachments, as long as they are using the same methods as the base game.

Workshop ID: 2920288546
Mod ID: spearcraftingfix
27 kommentarer
< >
Coldsteel 31. juli 2024 kl. 17:02 
I don't mean to be rude or anything. I did it as a proof that it's possible and it works. Ideally I'd want you to take the whole thing and put it into your mod, it would reach more people that way. BTW the SOMW part is identical to the normal code, it's just SOMW has an additional separate pair of these functions specifically for spears crafted out of planks.
Coldsteel 31. juli 2024 kl. 15:13 
I didn't use your code, and I didn't override anything. Which is how I'm not having issues with SOMW and WeaponModifiers compatibility.

https://psteamcommunity.yuanyoumao.com/sharedfiles/filedetails/?id=3300366479
Neidmare  [ophavsmand] 31. juli 2024 kl. 9:10 
@Coldsteel Sure, feel free to re-use the code. I think the other mod also replaces the original method though, so depending on load order it might not work.
Coldsteel 31. juli 2024 kl. 7:17 
@Neidmare well you can remake it such that it doesn't needs to entirely replace it. Since you overwrite the durability value anyway, you can let the original code finish before running your own.

I'm making mod that fixes a different spear issue and I can always just throw in a fixed version of your code in there too.
Neidmare  [ophavsmand] 31. juli 2024 kl. 7:09 
@Coldsteel Ah and the other thing is that my code replaces the vanilla method entirely
Neidmare  [ophavsmand] 31. juli 2024 kl. 7:04 
@Coldsteel IIRC, the load order of the mods is not fixed. If the other mod gets loaded later, it will overwrite my method.
Coldsteel 31. juli 2024 kl. 6:00 
@Neidmare I haven't looked at your code but this sort of issue is normally remedied by daisy chaining the calls instead of overwriting them.

local originalFunction = Recipe.OnCreate.UpgradeSpear
function Recipe.OnCreate.UpgradeSpear(...)
originalFunction(...)
your_code(...)
end
Neidmare  [ophavsmand] 22. juni 2024 kl. 0:41 
@cortex3973 I had a look at weapon modifiers. We overwrite the same method in the code. Not possible to make them compatible unfortunately.
Rezonaise 21. juni 2024 kl. 13:34 
mod dont work
Borris the Conqueror 10. maj 2024 kl. 17:04 
Cortex is indeed correct, mod doesn't work now and i too have Weapon Modifiers v1.1.3 installed as well