Sigh. Nevermind. Useful tool for modders:

http://jsonlint.com/

When you can't figure out what you broke... VALIDATE DAT JSON!

EDIT: Figured it out, I was missing a " mark on one trinket.


I've gone over this a few times and I don't see a typo. The only dodgy thing I did was add TRINKET_RANGEDONLYCRIT_B1 to something. I only think that is dodgy because while the buff exists in the buffs file, no other trinket was using it.

Full file below if anyone cares to peak:

http://pastebin.com/Qec16uyC

I imagine :) Did you ever introduce a bug in your base.entries.trinkets.json that messed up save files? :D Right now I must have done something wrong, because the game won't crash, but it also won't save any gold (or heirlooms) you've earned between quests :D

Welp, I'm at a loss. These specific lines are causing the issue:

//effect .name "Maiming Shot 1" .target "target" .curio_result_type "negative" .chance 100% .combat_stat_buff 1 .speed_rating_add -4 .on_hit true .on_miss false .queue true
//effect .name "Maiming Shot 2" .target "target" .curio_result_type "negative" .chance 110% .combat_stat_buff 1 .speed_rating_add -5 .on_hit true .on_miss false .queue true
//effect .name "Maiming Shot 3" .target "target" .curio_result_type "negative" .chance 120% .combat_stat_buff 1 .speed_rating_add -6 .on_hit true .on_miss false .queue true
//effect .name "Maiming Shot 4" .target "target" .curio_result_type "negative" .chance 130% .combat_stat_buff 1 .speed_rating_add -7 .on_hit true .on_miss false .queue true
//effect .name "Maiming Shot 5" .target "target" .curio_result_type "negative" .chance 140% .combat_stat_buff 1 .speed_rating_add -8 .on_hit true .on_miss false .queue true

After I commented just those out it works now. I did remove the .0 from a few % numbers like St. Michaels suggested, but I'm not sure that mattered. Those lines were likely copied from elsewhere in the doc and slightly modified, just like the ones above...

edit: derp. effect needs : in front of it.........

I actually tried only loading effects.darkest to isolate the problem :) This file is definitely bugging out by itself, regardless of what others are doing.

https://www.diffchecker.com/bRIsP8h1

My file on the right, original game version on the left. I've gone over this for the last hour and can't for the life of me spot the game breaking error I've created.

One possibility I suppose is that you can't mix DoTs with .combat_stat_buff ? They have to be distinct effects? If it is that simple then there is at least one change I know I need to make, but I don't have time to test it right now. Will try later and report back.

Say someone spent the last 4 hours making changes to each class and also effects.darkest. Then they go to test their mod and it crashes to desktop on attempting to load because of a typo somewhere in one of the 12+ files they were modifying.... Totally wasn't what I just experienced tonight (Ok yes it was, I was that guy).

Right now the hunt for typo-related bugs is pretty terrible if you don't test frequently when changing lots of files. It sure would be great if there was error handling in the case of a .info or .darkest file attempting to load and breaking the game's schema. Then if that error handling could tell you which file the game just choked on, or even WHICH LINE??? (in that file) all the better :O

Can confirm, I was having a similar issue until I reduced my description to the word "description", then it ran the uploader correctly. Prior to that it was telling me it couldn't find a valid ModDataPath or Title.

Ahoy everyone. I'm already familiar with Maester Silvio who was a big help when I was figuring out the early versions of Darkest Night, Brightest Dawn. My work centered around quality of life in Vanilla (feels like a long time ago now, though!). I wanted to open up more viable team compositions by changing specific skills in small ways (opening up more positions to use them from, changing potential targets, mostly). Some small numbers buffs where I felt a skill was just non-competitive with other available options. In addition, I turned some attention towards balancing the town grind (prior to being able to trade town resources), and making trinkets more competitive by again buffing the least appealing ones. A lot of that just involved removing the drawbacks from most of them :)

All this number tweaking was hard to maintain between game version updates, so I'm very excited to see what the official modding support will be like. Easing the transition between versions (patches, DLC updates) of vanilla Darkest Dungeon itself for modders would be great if Red Hook could make that a priority (after that concurrent file limit that Maester Silvio described).

I'm from the USA and a military vet. I graduated in Computer Science at Wright State University after that was over with. I'm jealous of Red Hook for being from Canada, but I work from home right now so I just treat my house like a Canadian annex in the US :)